[babel 8] Remove loose and spec options from preset-env#16043
Merged
Conversation
nicolo-ribaudo
added
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55920/ |
Contributor
|
@nicolo-ribaudo Can you rebase? |
nicolo-ribaudo
force-pushed
the
env-remove-loose
branch
from
November 27, 2023 15:32
92133b5 to
9c6a897
Compare
nicolo-ribaudo
force-pushed
the
env-remove-loose
branch
from
November 29, 2023 12:05
9c6a897 to
ae80072
Compare
liuxingbaoyu
approved these changes
Dec 10, 2023
liuxingbaoyu
left a comment
liuxingbaoyu
left a comment
Member
There was a problem hiding this comment.
I'm in favor of removing loose in plugins to maintain uniformity.
JLHwung
approved these changes
Dec 10, 2023
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the spirit of https://github.com/babel/rfcs/blob/main/rfcs/0003-top-level-assumptions.md, I think we should remove the
looseandspecoptions from@babel/preset-env. They are not descriptive,looseenables a lot of compilation differences without letting people actually choose what they want.The assumptions docs should have the equivalent
assumptionsconfiguration for those two options, so that people migrating can simply copy&paste them as a starting point.I also think that the individual
looseoptions in the various plugins are bad, but I feel less strongly about removing them.