Skip to content

Fully support || and && in pluginToggleBooleanFlag#15961

Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo:plugin-toggle-boolan-flag-suport-conditions
Sep 14, 2023
Merged

Fully support || and && in pluginToggleBooleanFlag#15961
nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo:plugin-toggle-boolan-flag-suport-conditions

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Sep 12, 2023

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is mostly needed this to cleanup #15955. Review with whitespace diff disabled.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 12, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55449/

@nicolo-ribaudo nicolo-ribaudo force-pushed the plugin-toggle-boolan-flag-suport-conditions branch from ce498a6 to 8b3cf33 Compare September 12, 2023 14:27
Comment thread packages/babel-preset-env/src/available-plugins.ts
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@nicolo-ribaudo nicolo-ribaudo merged commit 3ed28b2 into babel:main Sep 14, 2023
@nicolo-ribaudo nicolo-ribaudo deleted the plugin-toggle-boolan-flag-suport-conditions branch September 14, 2023 22:39
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 15, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants