Skip to content

More misc Babel 8 little changes#15550

Merged
nicolo-ribaudo merged 3 commits into
babel:mainfrom
nicolo-ribaudo:misc-babel-8
Apr 19, 2023
Merged

More misc Babel 8 little changes#15550
nicolo-ribaudo merged 3 commits into
babel:mainfrom
nicolo-ribaudo:misc-babel-8

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Apr 5, 2023 •
edited by JLHwung
Loading

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2765
Any Dependency Changes?
License MIT

This is not exhaustive, but I have fixed some more `TODO(Babel 8) comments (part 1: #15068)

nicolo-ribaudo
nicolo-ribaudo commented Apr 5, 2023
View reviewed changes
Comment thread packages/babel-helper-builder-binary-assignment-operator-visitor/package.json
},
"main": "./lib/index.js",
"dependencies": {
"@babel/helper-explode-assignable-expression": "workspace:^",

@nicolo-ribaudo nicolo-ribaudo Apr 5, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package had some TODO(Babel 8) comments regarding its public interface. It was only used in @babel/helper-builder-binary-assignment-operator-visitor, so I inlined it in packages/babel-helper-builder-binary-assignment-operator-visitor/src/explode-assignable-expression.ts and made the necessary changes (basically, removing the allowedSingleIdent and file parameters from the explode function).

After this PR is merged, I'll move the package to https://github.com/babel/babel-archive.

@babel-bot

babel-bot commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54270/

@JLHwung JLHwung mentioned this pull request Apr 5, 2023
Merged
@bba615523

This comment was marked as spam.

Sign in to view
@nicolo-ribaudo
nicolo-ribaudo requested a review from JLHwung April 13, 2023 10:46
@nicolo-ribaudo
nicolo-ribaudo merged commit f3e9aee into babel:main Apr 19, 2023
@nicolo-ribaudo
nicolo-ribaudo deleted the misc-babel-8 branch April 19, 2023 09:29
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 20, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 20, 2023
@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 9, 2023
@JLHwung JLHwung added this to the v8.0.0 milestone Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @babel-bot @bba615523 @JLHwung