chore: Use babel.config.cts
#15511
Closed
chore: Use babel.config.cts
#15511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
commented
Mar 24, 2023
Comment on lines
-740
to
+777
| pathUtils.join(dir, `${source.value}/package.json`) | ||
| ), | ||
| "utf8" | ||
| pathUtils.join(dir, `${source.value}/package.json`), | ||
| "utf8" | ||
| ) |
Member
Author
There was a problem hiding this comment.
Previously we accidentally passed utf8 to JSON.parse.
liuxingbaoyu
commented
Mar 24, 2023
| { | ||
| configFile: false, | ||
| parserOpts: { attachComments: false, plugins: ["typescript"] }, | ||
| parserOpts: { attachComment: false, plugins: ["typescript"] }, |
Member
Author
There was a problem hiding this comment.
There is a typo here.
nicolo-ribaudo
force-pushed
the
cts-config
branch
from
9c42bfe to
a2628fb
Compare
nicolo-ribaudo
force-pushed
the
cts-config
branch
from
a2628fb to
434c41a
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54216/ |
| const { source } = node; | ||
| if (!source) return; |
Member
There was a problem hiding this comment.
This change is causing the CI failure
Member
Author
|
This seems to be a compatibility issue with older versions of jest, I'll look into it. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2ref: #15478
During the migration I found two bugs, but luckily they worked by accident.