Skip to content

Reduce warnings for deprecated node aliases #15448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 1 commit into from
Feb 21, 2023
Merged

Reduce warnings for deprecated node aliases #15448

nicolo-ribaudo merged 1 commit into from
Feb 21, 2023

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 21, 2023 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Warning for deprecated nodes or aliases can be very noisy. We use console.trace so that users know which of their dependencies is using it, but it causes ~10 stack frames per usage of the deprecated aliases by default. With this PR:

  • we use console.warn instead of console.trace, since we are emitting a warning
  • we only output 2 stack frames: last one in user code, and the first one inside Babel
  • we only warn once per deprecated alias, instead of once per usage per deprecated alias

Ref #15266, lodash/babel-plugin-lodash#259

@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 💅 A type of pull request used for our changelog categories label Feb 21, 2023
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 21, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53999/

liuxingbaoyu
liuxingbaoyu approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolo-ribaudo nicolo-ribaudo merged commit 61be17e into babel:main Feb 21, 2023
@nicolo-ribaudo nicolo-ribaudo deleted the warn-less branch February 21, 2023 17:03
@samuelslva-jlfs samuelslva-jlfs mentioned this pull request Feb 22, 2023
Open
This was referenced Feb 22, 2023
Closed
Merged
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 10, 2023
Merged
@ClearlyClaire ClearlyClaire mentioned this pull request Mar 10, 2023
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu