fix: Handling source maps without sourcesContent
#15445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxingbaoyu
added
PR: Bug Fix 🐛
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53994/ |
1 task
JLHwung
approved these changes
Feb 20, 2023
jridgewell
reviewed
Feb 22, 2023
| map, | ||
| resolvedSources[i], | ||
| this._inputMap.sourcesContent[i], | ||
| this._inputMap.sourcesContent?.[i], |
Member
There was a problem hiding this comment.
Nit: We can skip this full loop if there's no sourcesContent.
Member
Author
There was a problem hiding this comment.
Does this affect sources? At first I skipped the whole loop, but then I'm not sure if sources will be preserved.
Member
There was a problem hiding this comment.
Instead of eagerly adding all sources, it'll only adds source as they are marked. It's not important to keep a source that was input if that source is never seen in the map, but setting a sourcesContent forces it.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #15022
@nicolo-ribaudo @JLHwung This seems to be a regression affecting quite a few people, let's release a patch, thanks!