Add back "moduleName" option to @babel/plugin-transform-runtime
#15426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: New Feature 🚀
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53911/ |
liuxingbaoyu
approved these changes
Feb 15, 2023
Comment on lines
94
to
101
| const { | ||
| moduleName = corejsVersion === 3 | ||
| ? "@babel/runtime-corejs3" | ||
| : corejsVersion === 2 | ||
| ? "@babel/runtime-corejs2" | ||
| : "@babel/runtime", | ||
| } = options; | ||
|
|
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I slightly prefer to have it at the top so that we have (roughly, because there is the logic to compute the corejsVersion variable):
- get the various options, with their default values
- validate all the options
- throw about old options
- the rest of the plugin logic
Member
There was a problem hiding this comment.
ljharb
approved these changes
Feb 15, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
babel-plugin-polyfill-corejs3and@babel/runtimeseparately, which is technically the recommended config since it clearly splits handling of helpers and polyfills (which are two separate concepts, and we just happened to handle them together for historical reasons),@babel/plugin-transform-runtimeinjects helpers imports to the version of@babel/runtimewhich internally doesn't use core-js polyfills (i.e. not@babel/runtime-corejs3).This option was already supported in Babel 6, but it had been removed in #8266.
This fixes babel/babel-polyfills#128 (comment) (@emmyakin, sorry for being one year late 😬)
The new config would be
{ "plugins": [ ["@babel/plugin-transform-runtime", { "moduleName": "@babel/runtime-corejs3" }], ["babel-plugin-polyfill-corejs3", { "method": "usage-pure" }] ] }Additionally, this option would potentially allow users to use different forks of
@babel/runtimewith their own different sets of polyfills.