refactor: remove ModuleDeclaration usage #15236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
force-pushed
the
remove-module-declaration-alias-usage
branch
from
7acbf59 to
c4e49b1
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53572/ |
Member
|
Note: it's now a Stage 2 proposal. |
nicolo-ribaudo
approved these changes
Dec 5, 2022
| - [ClassPrivateProperty](#classprivateproperty) | ||
| - [StaticBlock](#staticblock) | ||
| - [ClassDeclaration](#classdeclaration) | ||
| - [ClassExpression](#classexpression) |
Member
There was a problem hiding this comment.
Is this file auto-generated?
Contributor
Author
There was a problem hiding this comment.
No. It seems to me this file is modified from the estree spec. We could somehow generate it if we move the labelling/descriptions to source comments.
existentialism
approved these changes
Dec 5, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step of deprecating the
ModuleDeclarationalias in light of the AST typeModuleDeclarationproposed in the Stage 1 proposal. It replaces current alias usage to a union of ImportDeclaration and ExportDeclaration.The AST spec changes are editorial.