Babel 8 misc changes #15068

JLHwung · 2022-10-24T20:23:20Z

Q	A
Fixed Issues?	Clean up Babel 8 todo comments
Patch: Bug Fix?
Major: Breaking Change?	Yes
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link	babel/website#2765
Any Dependency Changes?
License	MIT

This PR should be reviewed by commits. It cleanups some Babel 8 todo comments. This PR also unifies current slightly different Babel 8 todo comments to TODO(Babel 8).

babel-bot · 2022-10-24T20:26:04Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54241/

liuxingbaoyu · 2022-11-11T16:46:55Z

.github/workflows/ci.yml

-          node-version: "14.17" # Node.js 14.17 is the first LTS supported by Babel 8
+          node-version: latest
+          check-latest: true


~~I'm worried this will cause some issues to go undetected.~~

Not related to this PR: Do we have a minimum node version requirement for the repository (build and development)

Do we have a minimum node version requirement for the repository (build and development)

Currently no. Personally I build / develop on latest Node and upgrade my environment every week. I believe using latest node is important:

If any node update breaks our build pipeline, we can always fallback to an older version temporarily. (IIRC in the past this scenario only happened in major upgrade)

Pinning node version will deprive us the benefit of latest build tools, e.g. Jest / Yarn will drop unmaintained node versions

Makes sense. I also currently always keep the latest major version.

JLHwung · 2022-11-11T17:16:18Z

packages/babel-compat-data/native-modules.js

-module.exports = require("./data/native-modules.json");
+module.exports = process.env.BABEL_8_BREAKING
+  ? require("./data/native-modules-next.json")
+  : require("./data/native-modules.json");


The flag here will ship to end users because we didn't run Babel on these CJS proxies.

Can we do this using rollup?

JLHwung · 2022-11-11T17:30:37Z

.github/workflows/ci.yml

      - name: Extract artifacts
        run: tar -xf babel-artifact.tar; rm babel-artifact.tar
-      - name: Generate runtime helpers
-        run: make build-plugin-transform-runtime-dist


This change should have been included in #15165.

liuxingbaoyu · 2022-11-12T17:51:20Z

babel/babel.config.js

Lines 125 to 128 in 5f19f62

    
           case "test": 
        
             targets = { node: "current" }; 
        
             needsPolyfillsForOldNode = true; 
        
             break;

I seem to have had this problem. Because it will use the current node version of the build.

JLHwung · 2022-11-13T16:41:25Z

.github/workflows/ci.yml

+          make -j build-standalone-ci
        env:
-          BABEL_ENV: test
+          BABEL_ENV: test-legacy


The test-legacy was introduced when we upgraded to Jest 25 which dropped Node.js 6. So we build on latest Node but targeted to a legacy Node version. However, in the Babel 8 situation, Node.js 14 is not a legacy version but a minimum supported one.

Maybe we can merge test-legacy with test, and then we differentiate node target by the CI environment variable. So that if a contributor runs yarn jest, he/she is testing against a build targeted to latest Node, which almost involves no transforms. If CI runs yarn jest, it is testing against the production build.

JLHwung · 2023-03-06T19:00:49Z

@nicolo-ribaudo Thanks for rebasing!

nicolo-ribaudo

These two comments are about the same topic, and if you want I can work on them (since I have a fresh copy of this branch, just rebased)

nicolo-ribaudo · 2023-03-06T19:13:52Z

packages/babel-compat-data/scripts/build-data.js

-    newData = defineLegacyPluginAliases(newData);
+    if (!process.env.BABEL_8_BREAKING) {
+      newData = defineLegacyPluginAliases(newData);
+    }


I dislike how this causes us to ship both Babel 7 and Babel 8 data to our users, as well as we then need to keep the flag in the CJS proxies (like packages/babel-compat-data/plugin-bugfixes.js)

I agree. I think it is fine to keep -next.json in the git repo but we can skip them during publish. As for Babel 8 resolving, maybe we can add yarn condition on the exports of @babel/compa-data and redirect ./plugins.json to ./plugins-next.json.

nicolo-ribaudo · 2023-03-06T19:14:56Z

packages/babel-compat-data/scripts/utils-build-data.js

    const currentData = fs.readFileSync(dataPath, "utf8");

    // Compare as JSON strings to also check keys ordering
    if (currentData !== stringified) {


Since the Babel 7 data is a superset of the Babel 8 data (thus the Babel 8 build would also work with the Babel 7 data), can we instead only generate the Babel 8 file when process.env.BABEL_8_BREAKING && process.env.IS_PUBLISH, and skip this check in that case?

JLHwung · 2023-03-06T22:12:59Z

packages/babel-cli/test/fixtures/babel/dir --out-dir --watch multiple dir/stderr.txt

@@ -0,0 +1 @@
+EXECUTOR TIMEOUT


This file should be removed.

(For some reasons this test keeps failing on my local environment and I must accidentally checkout them out)

It also keeps failing on my local environment, it's possible I checked it out while rebasing. I spent one hours trying to understand what was wrong with my local env, I'm "happy" that it's not just me 😅

JLHwung · 2023-03-06T22:25:42Z

@nicolo-ribaudo Thank you! Yeah you can work on this branch and feel free to overhaul anything.

nicolo-ribaudo · 2023-03-07T09:22:31Z

#15473 is necessary to fix the preset-env stdout difference between Babel 7 and Babel 8 (I rebased this PR on top of that one).

JLHwung added the babel-8-dev → main label Oct 24, 2022

JLHwung force-pushed the babel-8-misc-changes branch from 16fd76f to eb7eed7 Compare November 11, 2022 16:41

liuxingbaoyu reviewed Nov 11, 2022

View reviewed changes

JLHwung commented Nov 11, 2022

View reviewed changes

JLHwung mentioned this pull request Nov 11, 2022

Bump babel deps #15187

Merged

JLHwung force-pushed the babel-8-misc-changes branch from e0896ba to 2f6ca5d Compare November 12, 2022 17:22

JLHwung force-pushed the babel-8-misc-changes branch from 657c59e to e29b216 Compare November 13, 2022 16:27

JLHwung commented Nov 13, 2022

View reviewed changes

JLHwung marked this pull request as ready for review November 14, 2022 16:51

nicolo-ribaudo force-pushed the babel-8-misc-changes branch from e29b216 to 4b1c812 Compare March 6, 2023 18:41

nicolo-ribaudo reviewed Mar 6, 2023

View reviewed changes

nicolo-ribaudo mentioned this pull request Mar 6, 2023

(tests) Log transform- instead of proposal- in preset-env #15473

Merged

JLHwung commented Mar 6, 2023

View reviewed changes

nicolo-ribaudo force-pushed the babel-8-misc-changes branch from c9d994c to 3775e19 Compare March 7, 2023 08:43

nicolo-ribaudo force-pushed the babel-8-misc-changes branch from 13291ff to f40d58b Compare March 7, 2023 14:01

JLHwung added 9 commits April 5, 2023 12:12

throw if filter is used with automatic runtime

e2dd3be

use babel.transformFileAsync

9865f4e

remove ios_saf from module supports

554225d

use logical assignment in scripts

c112c51

unify todo(babel 8) comment format

73929cf

remove legacy plugin aliases in Babel 8

303f291

avoid shadowing process

de47b55

build Babel 8 artifacts using latest node

d3c6297

breaking: build Babel 8 compat-data

35db17f

JLHwung and others added 7 commits April 5, 2023 12:13

preserve corejs2-built-ins

5627ecd

runtime helpers are included in artifacts

c3b4e76

update Babel 8 test fixtures

681992f

target to 14.15 for Babel 8 build

f19ce4d

Only generate Babel 8 data when publishing Babel 8

69b753b

Add back different exports for compat-data in Babel 8

9dff5ed

Update fixtures after rebase

2e02553

nicolo-ribaudo force-pushed the babel-8-misc-changes branch from f40d58b to 2e02553 Compare April 5, 2023 10:22

nicolo-ribaudo approved these changes Apr 5, 2023

View reviewed changes

nicolo-ribaudo merged commit 0a1cfc0 into babel:main Apr 5, 2023

nicolo-ribaudo deleted the babel-8-misc-changes branch April 5, 2023 11:47

nicolo-ribaudo mentioned this pull request Apr 5, 2023

More misc Babel 8 little changes #15550

Merged

JLHwung added a commit to JLHwung/babel-website that referenced this pull request Apr 14, 2023

add breaking changes from babel/babel#15068

61d2400

liuxingbaoyu mentioned this pull request Apr 29, 2023

fix: Not found corejs3-shipped-proposals.json #15598

Merged

JLHwung added a commit to JLHwung/babel-website that referenced this pull request May 5, 2023

add breaking changes from babel/babel#15068

270c461

JLHwung added a commit to JLHwung/babel-website that referenced this pull request May 10, 2023

add breaking changes from babel/babel#15068

ddf6d99

JLHwung added a commit to JLHwung/babel-website that referenced this pull request May 10, 2023

add breaking changes from babel/babel#15068

4977b82

JLHwung added a commit to JLHwung/babel-website that referenced this pull request May 30, 2023

add breaking changes from babel/babel#15068

831caea

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 6, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023

nicolo-ribaudo added babel 8 and removed babel-8-dev → main labels Aug 8, 2023

JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 9, 2023

JLHwung added this to the v8.0.0 milestone Aug 9, 2023

Uh oh!

Babel 8 misc changes #15068

Babel 8 misc changes #15068

Uh oh!

Conversation

JLHwung commented Oct 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Oct 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxingbaoyu Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLHwung Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liuxingbaoyu commented Nov 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLHwung commented Mar 6, 2023

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLHwung commented Mar 6, 2023

Uh oh!

nicolo-ribaudo commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JLHwung commented Oct 24, 2022 •

edited

Loading

babel-bot commented Oct 24, 2022 •

edited

Loading

liuxingbaoyu Nov 11, 2022 •

edited

Loading

JLHwung Nov 11, 2022 •

edited

Loading

nicolo-ribaudo commented Mar 7, 2023 •

edited

Loading