Fix "Cannot read properties of undefined" regression #15031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53126/ |
liuxingbaoyu
approved these changes
Oct 10, 2022
| for (let i = 0; i < len; i++) { | ||
| const comment = comments[i]; | ||
|
|
||
| if (hasLoc && "loc" in comment && !this._printedComments.has(comment)) { |
Member
There was a problem hiding this comment.
Maybe judge comment.loc != null directly here?
liuxingbaoyu
added
pkg: generator
i: regression
PR: Bug Fix 🐛
Member
|
What is a test that shows the crash? |
Member
|
This should be the case when |
Member
|
This is in the main branch, I can't push, merge it first? |
nicolo-ribaudo
changed the title
|
Thanks! We were seeing this in CI here if it helps: https://github.com/redwoodjs/redwood/actions/runs/3220457113/jobs/5267202329#step:12:81 |
19 tasks
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch: 'end or start' of undefined