Implement support for internal @babel/core plugins #14966

nicolo-ribaudo · 2022-09-22T16:50:08Z

Q	A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

This is my first pass at implementing babel/rfcs#10. I didn't think about and responded to all the feedback yet.

So far this PR includes all the plugins in @babel/core, and it's possible to do so already in v7 by just adding them as dependencies.

We now have a lot of @babel-core----(dependency)--->@babe/plugin-...---->(peerDependency)--->@babel/core cycles, but apparently we already had a @babel-core----(dependency)--->@babe/helper-compilation-targets---->(peerDependency)--->@babel/core cycle and no one complained, so it works in all the package managers.
Doing it this way doesn't give us any of the benefits of the RFC, except that we can start exposing in Babel 7 the same API that we will have in Babel 8.
EDIT There is a big benefit I didn't think about: by simply updating @babel/core, users can make sure that all their plugin for stable features are up to date.

~~I still need to actually use the internal plugins in @babel/preset-env, to check that everything works.~~

Additionally, while going through the list of all the stable plugins I noticed that some of them may benefit from a rename that either makes it more clear what they do, or makes their name consistent with the name of other plugins. You can read my proposals as comments in packages/babel-core/src/transformation/internal-plugins.ts.

babel-bot · 2022-09-22T16:53:42Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53739/

nicolo-ribaudo · 2022-10-06T13:36:09Z

This is ready for review. This change isn't much useful per se, because we cannot really move the plugins currently used by @babel/preset-env to @babel/core otherwise they would all be duplicated (once in @babel/preset-env's dependencies, and once inside @babel/core's source). However:

this PR prepares all the infrastructure, and as soon as we have to move a new plugin to @babel/preset-env we can do so by making it a "real" internal @babel/core plugin rather than a new dependency. I'm eagerly waiting for a proposal to get to Stage 4 :)
this PR doesn't change the size of the @babel/core & @babel/preset-env combo.
~~this PR doesn't move bugfix plugins yet into @babel/core, we can discuss if we should do it or not (probably yes?), but this PR is already quite big and we don't need to move them now.~~

While reviewing, please take a look at the comments in packages/babel-core/src/transformation/internal-plugins.ts because I would like to decide the naming before merging (otherwise we have to wait for Babel 8)

JLHwung · 2022-10-26T18:20:52Z

packages/babel-preset-env/src/available-plugins.ts

+
+  if (
+    desc.internal !== false &&
+    // TODO: Change 7.19.0 to the first version supporting internal plugins


It should be added to the make new-version-checklist.

JLHwung · 2022-10-26T18:23:37Z

packages/babel-core/package.json

    "@babel/helper-module-transforms": "workspace:^",
    "@babel/helpers": "workspace:^",
    "@babel/parser": "workspace:^",
+    "@babel/plugin-proposal-async-generator-functions": "workspace:^",


Q: Should we also internalize @babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression and @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining?

Since we will defaults to bugfixes: true in Babel 8, I think they should be included in internal plugin set.

Done 👍 I've left @babel/preset-modules out for now; we can decide what to do with it in the future :)

nicolo-ribaudo · 2023-02-09T17:37:12Z

I would love to receive some feedback on the plugin renaming suggested in the comment in internal-plugins.ts, even from those that will not review this.

While going through the list of all plugins, I noticed that some of them had very inconsistent naming. We have multiple options:

don't rename them
rename them now for the internal plugins, and keep the old name for the plugin packages
don't rename them now, add aliases later for the internal plugins, and keep the old name for the plugin packages. Remove the old names in Babel 8.
don't rename them now, and do the rename in Babel 8.0.0.

liuxingbaoyu · 2023-02-09T18:21:58Z

I'm a little concerned that this PR is blurring the distinction between @babel/core and @babel/preset-env.
Previously @babel/core was a framework, while @babel/preset-env resembled a convenient collection of plugins.
Now a large number of plugins are included in @babel/core, and only a few remain in @babel/preset-env, which is not very ideal.

At the same time, the advantages of purpose also have some limitations.
Mainly it is the proposals that reach the fourth stage to benefit, but they are rarely affected by @babel/core, @babel/traverse, because bug fixes and standard alignment also happen more in <=3 proposals and ts. (now the ts plugin is widely used, and ts fixes and feature support often want newer @babel/core)

The main way I understand in rfc to encourage users to upgrade is to deprecate the proposal that becomes the fourth phase, and use the package manager to remind users to upgrade @babel/core.
This appears to be a "soft limit" only, we still need compatibility for older versions of @babel/core. And once we implement "hard limits", the soft limits will no longer be necessary and we will be able to reap most of these benefits.

But I don't block this PR, I just want to have more detailed discussions. 😃

JLHwung · 2023-02-09T19:42:29Z

packages/babel-core/src/transformation/internal-plugins.ts

+
+  // ES2021
+  "logical-assignment-operators": () => proposalLogicalAssignmentOperators,
+  "numeric-separator": () => proposalNumericSeparator, // RENAME: numeric-separators


For most plugins after ES2021, they are named from the corresponding proposal slug:

https://github.com/tc39/proposal-numeric-separator
https://github.com/tc39/proposal-class-static-block

I believe it is straightforward if you want to try out a plugin after you learn that proposal. If TC39 can somehow enforce consistent naming among proposals, that would be great. Otherwise I suggest we rename it but keep old name as an alias.

I can discuss it with other TC39 delegates.

nicolo-ribaudo · 2023-02-10T08:07:27Z

(I replied to @liuxingbaoyu in babel/rfcs#10)

nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: core labels Sep 22, 2022

nicolo-ribaudo mentioned this pull request Sep 24, 2022

Internally rename proposal-* to transform-* in preset-env #14976

Merged

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch 3 times, most recently from 51bc1b1 to c19dc31 Compare September 29, 2022 13:32

nicolo-ribaudo marked this pull request as ready for review October 6, 2022 13:36

JLHwung reviewed Oct 26, 2022

View reviewed changes

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch from c19dc31 to 6c0d573 Compare October 28, 2022 20:09

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch from 6c0d573 to 71b59ee Compare November 5, 2022 14:03

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch from 71b59ee to f089bc8 Compare November 28, 2022 10:59

nicolo-ribaudo added this to the v7.21.0 milestone Dec 6, 2022

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch from bbf73ac to 9ce2fb7 Compare December 7, 2022 11:07

JLHwung self-requested a review December 7, 2022 15:42

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch from 9ce2fb7 to ef7e6ed Compare December 15, 2022 14:19

nicolo-ribaudo added 9 commits January 2, 2023 15:56

Implement support for internal @babel/core plugins

0353ef0

All transform-* plugins except for transform-modules-*

2fd5801

Add "proposal" plugins that are ow standard

867f274

Use internal plugins in preset-env

477f773

new-version-checklist

fb1317c

Move monorepo bugfix plugins to core

9a5989a

Fix after rebase

b852f41

Fix linting after rebase

a9edc16

make build-compat-data

56346f2

nicolo-ribaudo force-pushed the rfc-plugins-into-core branch from ef7e6ed to 56346f2 Compare January 2, 2023 14:57

nicolo-ribaudo added the PR: Needs Docs label Feb 6, 2023

nicolo-ribaudo requested a review from liuxingbaoyu February 8, 2023 20:10

nicolo-ribaudo added the PR: Needs Review A pull request awaiting more approvals label Feb 8, 2023

JLHwung reviewed Feb 9, 2023

View reviewed changes

nicolo-ribaudo removed this from the v7.21.0 milestone Feb 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Implement support for internal @babel/core plugins #14966

Implement support for internal @babel/core plugins #14966

Uh oh!

nicolo-ribaudo commented Sep 22, 2022 •

edited

Loading

Uh oh!

babel-bot commented Sep 22, 2022 •

edited

Loading

Uh oh!

nicolo-ribaudo commented Oct 6, 2022 •

edited

Loading

Uh oh!

JLHwung Oct 26, 2022

Uh oh!

JLHwung Oct 26, 2022

Uh oh!

nicolo-ribaudo Oct 28, 2022

Uh oh!

nicolo-ribaudo commented Feb 9, 2023

Uh oh!

liuxingbaoyu commented Feb 9, 2023

Uh oh!

JLHwung Feb 9, 2023

Uh oh!

nicolo-ribaudo Feb 10, 2023

Uh oh!

nicolo-ribaudo commented Feb 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Implement support for internal @babel/core plugins #14966

Are you sure you want to change the base?

Implement support for internal @babel/core plugins #14966

Uh oh!

Conversation

nicolo-ribaudo commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Oct 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLHwung Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

JLHwung Oct 26, 2022

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo commented Feb 9, 2023

Uh oh!

liuxingbaoyu commented Feb 9, 2023

Uh oh!

JLHwung Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo Feb 10, 2023

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo commented Feb 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nicolo-ribaudo commented Sep 22, 2022 •

edited

Loading

babel-bot commented Sep 22, 2022 •

edited

Loading

nicolo-ribaudo commented Oct 6, 2022 •

edited

Loading