Update typescript to 4.8 by JLHwung · Pull Request #14880 · babel/babel

JLHwung · 2022-08-26T00:44:56Z

Q	A
Any Dependency Changes?	Bump TS to 4.8 and fix new typing errors
License	MIT

Also removed babel-parser's tsconfig now that we have converted the parser to TS.

JLHwung · 2022-08-26T00:45:52Z

 }

-export function flattenToSet<T>(arr: ReadonlyDeepArray<T>): Set<T> {
+export function flattenToSet<T extends string>(


T is constrained to string so that Array.isArray(el) can effectively differentiate between ReadonlyDeepArray<T> and T.

babel-bot · 2022-08-26T00:48:17Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52822/

There is the OOM error you mentioned :/

liuxingbaoyu · 2022-08-26T09:16:03Z

This should be a new bug, not even enabling strictNullCheck. :)

liuxingbaoyu · 2022-08-26T10:19:40Z

ts4.7

PS F:\babel> yarn tsc --extendedDiagnostics --incremental false
Files:                          714
Lines of Library:             27958
Lines of Definitions:         48613
Lines of TypeScript:         109737
Lines of JavaScript:              0
Lines of JSON:                 4198
Lines of Other:                   0
Nodes of Library:            119371
Nodes of Definitions:        127849
Nodes of TypeScript:         416262
Nodes of JavaScript:              0
Nodes of JSON:                11813
Nodes of Other:                   0
Identifiers:                 230675
Symbols:                     959380
Types:                       380554
Instantiations:            42135598
Memory used:               1117681K
Assignability cache size:    262472
Identity cache size:          16941
Subtype cache size:          100724
Strict subtype cache size:     8524
I/O Read time:                0.08s
Parse time:                   0.75s
ResolveModule time:           0.18s
ResolveTypeReference time:    0.01s
Program time:                 1.11s
Bind time:                    0.42s
Check time:                  19.77s
transformTime time:           1.32s
Source Map time:              0.05s
commentTime time:             0.08s
I/O Write time:               0.26s
printTime time:               2.18s
Emit time:                    2.19s
Total time:                  23.49s

ts4.8

PS F:\babel> yarn tsc --extendedDiagnostics --incremental false
Files:                          715
Lines of Library:             28146
Lines of Definitions:         48613
Lines of TypeScript:         109741
Lines of JavaScript:              0
Lines of JSON:                 4198
Lines of Other:                   0
Nodes of Library:            118224
Nodes of Definitions:        126241
Nodes of TypeScript:         413313
Nodes of JavaScript:              0
Nodes of JSON:                11813
Nodes of Other:                   0
Identifiers:                 230557
Symbols:                    2992041
Types:                      1556880
Instantiations:            42130595
Memory used:               3987979K
Assignability cache size:    260473
Identity cache size:          16941
Subtype cache size:           99375
Strict subtype cache size:     9253
I/O Read time:                0.08s
Parse time:                   0.73s
ResolveModule time:           0.20s
ResolveTypeReference time:    0.01s
Program time:                 1.11s
Bind time:                    0.42s
Check time:                  57.65s
transformTime time:           1.84s
Source Map time:              0.05s
commentTime time:             0.09s
I/O Write time:               0.32s
printTime time:               2.84s
Emit time:                    2.84s
Total time:                  62.02s

This should be a regression.
Memory usage increased from 1gb to 4gb and time increased from 23s to 62s.
Chief among them is a suspicious increase in the number of Symbols and Types.

But I personally don't mind letting it merge first to avoid blocking our development progress.

nstepien · 2022-08-27T11:39:55Z

@liuxingbaoyu might be related microsoft/TypeScript#50290 (comment)

liuxingbaoyu · 2022-08-27T11:43:26Z

@nstepien
Thank you for your reminder!
I've seen that one, and it shows up as a massive increase in Assignability cache size, but here it's Symbols and Types.

liuxingbaoyu · 2022-08-27T18:33:49Z

I'm sure I don't know what's going on.😅

liuxingbaoyu · 2022-08-28T16:03:01Z

Yes, as you can see, the CI turns green after adding a magic any.

This might have something to do with this across files.
When I extract Scope to the same file, it throws error.

packages/babel-traverse/src/path/index.ts:157:24 - error TS2345: Argument of type 'this' is not assignable to parameter of type 'NodePath<Scopable | Pattern>'.
  Type 'NodePath<T>' is not assignable to type 'NodePath<Scopable | Pattern>'.
    Type 'T' is not assignable to type 'Scopable | Pattern'.
      Type 'Node' is not assignable to type 'Scopable | Pattern'.
        Type 'ArrayExpression' is not assignable to type 'Scopable | Pattern'.
          Type 'ArrayExpression' is not assignable to type 'ArrayPattern'.
            Types of property 'type' are incompatible.
              Type '"ArrayExpression"' is not assignable to type '"ArrayPattern"'.
                Type 'T' is not assignable to type 'WhileStatement'.
                  Type 'Node' is not assignable to type 'WhileStatement'.
                    Type 'ArrayExpression' is missing the following properties from type 'WhileStatement': test, body

157     let a = new Scope2(this);

I think we can merge first, since our NodePath is so complex, it's not trivial to make even a minimal reproduction.

This works, too, without any other side effects.

   getScope(scope: Scope): Scope {
     return this.isScope()
       ? new Scope(this as NodePath<t.Pattern | t.Scopable>)
       : scope;
   }

Co-authored-by: liuxingbaoyu <[email protected]>

JLHwung · 2022-08-29T13:33:42Z

When I extract Scope to the same file, it throws error.

Yeah the error is expected, new Scope must be guarded by the isScope check.

liuxingbaoyu · 2022-08-29T13:55:57Z

You're right, I seem to be closer to making a repo that reproduces, albeit just as complicated. 😂

JLHwung · 2022-08-29T14:04:53Z

@liuxingbaoyu A smaller reproduction will be great! I am drafting an issue to the TS repo. If you come up with a smaller reproduction, please let me know and I can update the issue.

liuxingbaoyu · 2022-08-29T14:24:19Z

https://github.com/liuxingbaoyu/babel-ts4.8-bug
To be honest, this might not be small enough for a human, but it's much more convenient for debugging and binary search.

JLHwung added 3 commits August 25, 2022 20:36

remove @babel/parser tsconfig

df77265

update typescript to 4.8

e4258ed

Fix new typing errors

d900d29

JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Dependency ⬆️ labels Aug 26, 2022

JLHwung commented Aug 26, 2022

View reviewed changes

nicolo-ribaudo previously approved these changes Aug 26, 2022

View reviewed changes

JLHwung marked this pull request as draft August 26, 2022 14:14

test

24a657e

nicolo-ribaudo reviewed Aug 28, 2022

View reviewed changes

Comment thread packages/babel-traverse/src/path/index.ts Outdated

liuxingbaoyu reviewed Aug 28, 2022

View reviewed changes

Comment thread packages/babel-traverse/src/path/index.ts Outdated

Update packages/babel-traverse/src/path/index.ts

39d5832

Co-authored-by: liuxingbaoyu <[email protected]>

liuxingbaoyu marked this pull request as ready for review August 29, 2022 13:55

liuxingbaoyu approved these changes Aug 29, 2022

View reviewed changes

JLHwung mentioned this pull request Aug 29, 2022

Performance issue on updating Babel monorepo typescript from 4.7.4 to 4.8.2 microsoft/TypeScript#50515

Closed

nicolo-ribaudo approved these changes Aug 29, 2022

View reviewed changes

nicolo-ribaudo merged commit 2626f18 into babel:main Aug 30, 2022

nicolo-ribaudo deleted the ts-4-8 branch August 30, 2022 09:47

shaneomatz mentioned this pull request Nov 18, 2022

[Snyk] Upgrade @babel/runtime from 7.12.5 to 7.20.0 shaneomatz/video.js#1

Open

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 30, 2022

github-actions Bot locked as resolved and limited conversation to collaborators Nov 30, 2022

Uh oh!

Uh oh!

Conversation

JLHwung commented Aug 26, 2022 • edited by gitpod-io Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLHwung Aug 26, 2022

Choose a reason for hiding this comment

Uh oh!

babel-bot commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxingbaoyu commented Aug 26, 2022

Uh oh!

liuxingbaoyu commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nstepien commented Aug 27, 2022

Uh oh!

liuxingbaoyu commented Aug 27, 2022

Uh oh!

liuxingbaoyu commented Aug 27, 2022

Uh oh!

liuxingbaoyu commented Aug 28, 2022

Uh oh!

Uh oh!

Uh oh!

JLHwung commented Aug 29, 2022

Uh oh!

liuxingbaoyu commented Aug 29, 2022

Uh oh!

JLHwung commented Aug 29, 2022

Uh oh!

liuxingbaoyu commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JLHwung commented Aug 26, 2022 •

edited by gitpod-io Bot

Loading

babel-bot commented Aug 26, 2022 •

edited

Loading

liuxingbaoyu commented Aug 26, 2022 •

edited

Loading