Repository navigation
Convert all SourceMapConsumers to TraceMaps - #14253
Merged
JLHwung merged 5 commits intoFeb 10, 2022
Merged
Conversation
This accomplishes 2 goals: - Gets us off the ancient `source-map` v0.5.7 - Speeds up construction and tracing by ~10x.
jridgewell
force-pushed
the
fixture-test-runner-trace-mapping
branch
from
February 9, 2022 05:03
37a3b17 to
7b0a467
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51221/ |
nicolo-ribaudo
approved these changes
Feb 9, 2022
nicolo-ribaudo
added
the
PR: Internal 🏠
JLHwung
approved these changes
Feb 9, 2022
| "@types/semver": "^5.4.0", | ||
| "@types/source-map": "^0.5.0", | ||
| "source-map": "0.6.1" | ||
| "@types/source-map": "^0.5.0" |
Contributor
There was a problem hiding this comment.
Do we still require the typings?
| "@babel/parser": "workspace:^", | ||
| "@jridgewell/trace-mapping": "^0.3.4", | ||
| "@types/jsesc": "^2.5.0", | ||
| "@types/source-map": "^0.5.0", |
Member
Author
There was a problem hiding this comment.
generator does, because it uses SourceMapGenerator. trace-mapping only offers a Consumer API.
JLHwung
approved these changes
Feb 10, 2022
Contributor
|
Merging as-is. The e2e error is unrelated to this PR. |
1 task
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accomplishes 2 things: