[babel 8] Align allow* parser options with ESLint behavior#13921
Merged
nicolo-ribaudo merged 2 commits intoNov 4, 2021
Conversation
nicolo-ribaudo
commented
Nov 2, 2021
| parseAndAssertSame('function F() { import a from "a"; }'); | ||
| }).toThrow( | ||
| new SyntaxError( | ||
| "'import' and 'export' may only appear at the top level", |
Member
Author
There was a problem hiding this comment.
This was a bad test: this error was thrown by espree, not by our parser.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49660/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3a1f251:
|
JLHwung
approved these changes
Nov 3, 2021
nicolo-ribaudo
force-pushed
the
allowSuperOutsideMethod-fix
branch
from
November 3, 2021 18:34
07118aa to
d227b9f
Compare
Member
Author
|
CI failure fixed by #13923 |
- The `@babel/eslint-parser` `allowImportExportEverywhere` option is removed; users can pass it to `parserOpts` - `allowSuperOutsideMethod` is disabled - `allowReturnOutsideFunction` is inferred from `ecmaFeatures.globalReturn`
nicolo-ribaudo
force-pushed
the
allowSuperOutsideMethod-fix
branch
from
November 4, 2021 00:16
d227b9f to
3a1f251
Compare
existentialism
approved these changes
Nov 4, 2021
github-actions
Bot
added
the
outdated
nicolo-ribaudo
added
PR: Breaking Change 💥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@babel/eslint-parserallowImportExportEverywhereoption is removed; users can pass it tobabelOptions.parserOpts.allowSuperOutsideMethodis disabled.allowReturnOutsideFunctionis inferred fromecmaFeatures.globalReturn. We already use it in other placesI added different non-babel-8 tests to validate the current behavior.