[babel 8] Enable preset-env bugfixes by default#13866
Merged
Merged
Conversation
JLHwung
commented
Oct 20, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5439a0b:
|
JLHwung
commented
Oct 20, 2021
| { | ||
| "targets": [ | ||
| "Chrome >= 60", | ||
| "Chrome >= 54", |
Contributor
Author
There was a problem hiding this comment.
The issue #9935 happens when async function is transpiled to generator functions but class is not transformed. Now that the bugfixes lowers the Safari's support of async functions, we will not see async function transpiled at all in the old targets settings. Here I lower the Chromium version to the latest without native async function support so we are still testing the regression 9935.
JLHwung
force-pushed
the
enable-bugfixes-by-default
branch
from
October 21, 2021 17:36
3fc3498 to
5439a0b
Compare
Contributor
Author
|
The CI error is unrelated, it is caused by yarnpkg/berry#3597 |
existentialism
approved these changes
Oct 21, 2021
Merged
nicolo-ribaudo
approved these changes
Oct 22, 2021
nicolo-ribaudo
changed the title
github-actions
Bot
added
the
outdated
JLHwung
added
PR: Breaking Change 💥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BABEL_8_BREAKINGflagIn this PR we enable the
bugfixespreset-env option by default in Babel 8. Most updated test fixtures already have related Babel 7 tests so we don't need to add new Babel 7 test fixtures.