Skip to content

[babel 8] Materialize ESTree's classFeatures option#13752

Merged
JLHwung merged 3 commits into
babel:mainfrom
nicolo-ribaudo:babel-8-estree-class-features
Sep 22, 2021
Merged

[babel 8] Materialize ESTree's classFeatures option#13752
JLHwung merged 3 commits into
babel:mainfrom
nicolo-ribaudo:babel-8-estree-class-features

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Sep 13, 2021 •
edited by JLHwung
Loading

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2765
Any Dependency Changes?
License MIT

@babel-bot

babel-bot commented Sep 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48808/

@codesandbox-ci

codesandbox-ci Bot commented Sep 13, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ffe070:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
nicolo-ribaudo marked this pull request as draft September 13, 2021 14:35
@nicolo-ribaudo
nicolo-ribaudo marked this pull request as ready for review September 13, 2021 14:52
@nicolo-ribaudo
nicolo-ribaudo marked this pull request as draft September 13, 2021 15:11
@nicolo-ribaudo

nicolo-ribaudo commented Sep 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

There is a bug in the ESTree plugin; I'll open a new PR to fix it.

#13755

@nicolo-ribaudo
nicolo-ribaudo force-pushed the babel-8-estree-class-features branch from 186ce19 to 776c875 Compare September 13, 2021 15:37
JLHwung
JLHwung reviewed Sep 13, 2021
View reviewed changes

@JLHwung JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's for Babel 8, I think we can actually remove this feature. The Babel eslint will also be bumped to support Babel 8 only.

@nicolo-ribaudo

nicolo-ribaudo commented Sep 14, 2021

Copy link
Copy Markdown
Member Author

Yeah, with "enable by default" actually meant "always enable, without checking for the flag".

@nicolo-ribaudo
nicolo-ribaudo force-pushed the babel-8-estree-class-features branch from 776c875 to ccee6b5 Compare September 14, 2021 15:16
@nicolo-ribaudo
nicolo-ribaudo marked this pull request as ready for review September 14, 2021 21:44
@nicolo-ribaudo
nicolo-ribaudo force-pushed the babel-8-estree-class-features branch from ccee6b5 to 2ffe070 Compare September 17, 2021 14:38
JLHwung
JLHwung approved these changes Sep 17, 2021
View reviewed changes

@JLHwung JLHwung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the PR title to "Materialize ESTree classFeatures option"? Since you can't disable it in Babel 8.

@nicolo-ribaudo nicolo-ribaudo changed the title [babel 8] Enable ESTree classFeatures by default in @babel/parser [babel 8] Materialize ESTree's classFeatures option Sep 17, 2021
@nicolo-ribaudo
nicolo-ribaudo requested a review from hzoo September 21, 2021 21:09
@JLHwung
JLHwung merged commit 2e2d202 into babel:main Sep 22, 2021
@nicolo-ribaudo
nicolo-ribaudo deleted the babel-8-estree-class-features branch September 22, 2021 19:36
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 23, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 23, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023
@nicolo-ribaudo nicolo-ribaudo added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hzoo hzoo hzoo approved these changes
@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

area: estree outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @babel-bot @hzoo @JLHwung