[Babel 8] Remove optional field from MemberExpression#13407
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46656/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 179bffa:
|
Contributor
|
The CI fails because we passed fourth argument (though used) of and we can remove it in Babel 7 since |
Member
Author
|
Ok I checked all usages of the builder and didn't find any other usages of the 4th param than the two usages mentioned above. |
JLHwung
approved these changes
Jun 3, 2021
JLHwung
changed the title
nicolo-ribaudo
changed the title
optional field from MemberExpression
github-actions
Bot
added
the
outdated
nicolo-ribaudo
added
PR: Internal (next major) 🏠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validation is already removed behind the flag, but the field should also be removed from the builder then.
It was added in #5813 before the optional-chaining was moved into its own AST node in #7288
I noticed this in v7 because I tried to compare AST nodes generated from the parser
foo.barto a manual generated nodetypes.memberExpression(types.identifier("foo"), types.identifier("bar"))and they did not match, because the builder always adds theoptionalfield (set to null).edit: Ok need to figure out the test problems first.