Skip to content

[TS] Create TSUnionType or TSIntersectionType when typealias has a leading operator #12758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 3 commits into from
Feb 5, 2021
Merged

[TS] Create TSUnionType or TSIntersectionType when typealias has a leading operator #12758

nicolo-ribaudo merged 3 commits into from
Feb 5, 2021

Conversation

@fedeci
Copy link
Member

@fedeci fedeci commented Feb 4, 2021 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? #12757 (comment)
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

If the intersection/union type has a leading | or & operator we create a TSUnionType/TSIntersectionType node even if it has just one type defined.

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 4, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39697/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 4, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb4b1bd:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@existentialism existentialism added area: typescript pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 4, 2021
JLHwung
JLHwung reviewed Feb 4, 2021
View reviewed changes
JLHwung
JLHwung approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit eccbcca into babel:main Feb 5, 2021
@fedeci fedeci deleted the union-type-leading-operator branch February 5, 2021 19:20
@sosukesuzuki sosukesuzuki mentioned this pull request Feb 19, 2021
Merged
14 tasks
@thorn0 thorn0 mentioned this pull request Mar 2, 2021
Merged
3 tasks
This was referenced Mar 11, 2021
Closed
Open
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

+1 more reviewer

@armano2 armano2 armano2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fedeci @babel-bot @existentialism @armano2 @JLHwung @nicolo-ribaudo