[babel 8] Remove module-specific options from @babel/core#12724
Merged
nicolo-ribaudo merged 4 commits intoMar 28, 2021
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44826/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8edc653:
|
nicolo-ribaudo
force-pushed
the
remove-top-level-module-options
branch
from
411a5c6 to
96f83ac
Compare
hzoo
approved these changes
Feb 2, 2021
nicolo-ribaudo
force-pushed
the
remove-top-level-module-options
branch
from
1e3ec25 to
956cb1b
Compare
nicolo-ribaudo
force-pushed
the
remove-top-level-module-options
branch
from
956cb1b to
9f58a3b
Compare
nicolo-ribaudo
commented
Mar 27, 2021
Comment on lines
+11
to
+14
| moduleId: rootOpts.moduleId ?? pluginOpts.moduleId, | ||
| moduleIds: rootOpts.moduleIds ?? pluginOpts.moduleIds, | ||
| getModuleId: rootOpts.getModuleId ?? pluginOpts.getModuleId, | ||
| moduleRoot: rootOpts.moduleRoot ?? pluginOpts.moduleRoot, |
Member
Author
There was a problem hiding this comment.
These should all be swapped
nicolo-ribaudo
commented
Mar 28, 2021
Member
Author
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
✔️ I haven't touched this PR for two months, so I re-reviewed it now with my reviewer hat 🤠
Member
Author
|
I also run the e2e Babel 8 tests |
github-actions
Bot
added
the
outdated
JLHwung
added
PR: Breaking Change 💥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BABEL_8_BREAKINGWe added these options to the various modules plugins in Babel 7.9.0 (#11194), and we can now remove them from
@babel/core.The first two commits update the two Yarn plugins that we use, to add them support for the
workspace:protocol nested inside thecondition:protocol. I tested them locally and they seem to work, but I'm marking this as draft until the e2e tests pass.