Implement constantReexports and enumerableModuleMeta assumptions
#12618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
nicolo-ribaudo
changed the base branch from
main
to
feat-7.13.0/babel-core-features
24 tasks
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37396/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e521f6e:
|
JLHwung
approved these changes
Jan 13, 2021
hzoo
reviewed
Jan 23, 2021
| if (!loose) { | ||
| initStatements.push(...buildReexportsFromMeta(metadata, data, loose)); | ||
| if (!constantReexports) { | ||
| initStatements.push(...buildReexportsFromMeta(metadata, data, false)); |
Member
There was a problem hiding this comment.
this should still be never mind, got confusedconstantReexports right?
hzoo
approved these changes
Jan 23, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 4, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 10, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 11, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 21, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR: #12219
RFC: babel/rfcs#5
I'm open to rename the second assumption (https://github.com/babel/rfcs/pull/5/files#r555969950)