[babel 8] Remove useSpread and useBuiltIns jsx options#12593
Merged
nicolo-ribaudo merged 2 commits intoJan 8, 2021
Merged
Conversation
backport of 8cc8696 Co-authored-by: Nicolò Ribaudo <[email protected]> Co-authored-by: Brian Ng <[email protected]>
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36920/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bf0335b:
|
JLHwung
approved these changes
Jan 8, 2021
hzoo
reviewed
Jan 8, 2021
| throw new Error( | ||
| "transform-react-jsx currently only accepts a boolean option for " + | ||
| "useSpread (defaults to false)", | ||
| '@babel/plugin-transform-react-jsx: Since Babel 8, an inline object with spread elements is always used, and the "useSpread" option is no longer available. Please remove it from your config.', |
Member
There was a problem hiding this comment.
Do we want a similar config message as useBuiltIns here if they want to compile?
Member
Author
There was a problem hiding this comment.
@babel/preset-env already compiles spread by default. We need the message for useBuiltIns because by default ... is not compiled to Object.assign.
hzoo
approved these changes
Jan 8, 2021
github-actions
Bot
added
the
outdated
nicolo-ribaudo
added
babel 8
PR: Breaking Change 💥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of 8cc8696 (#11141)