The first-line comment is removed unexpectedly #12558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36471/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 06153ec:
|
nicolo-ribaudo
added
area: comments
PR: Bug Fix 🐛
Comment on lines
23
to
27
| if (hasPrev && !hasNext) { | ||
| prev.addComments("trailing", trailing); | ||
| } else if (hasNext && !hasPrev) { | ||
| } else if (hasNext) { | ||
| next.addComments("leading", leading); | ||
| } |
Member
There was a problem hiding this comment.
I think the logic we had is wrong, and we should do something like this to avoid loosing comments?
if (hasPrev) {
prev.addComments("trailing", leading);
} else if (hasNext) {
next.addComments("leading", leading);
}
if (hasNext) {
next.addComments("leading", trailing);
} else if (hasPrev) {
prev.addComments("trailing", trailing);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #11971, the first comment is sometimes removed while it shouldn't. Consider the following snippet from the issue:
The bug occurs during the transformation of the AST. When the
ImportDeclarationnode is removed, its leading comment should be transferred to one of its new sibling nodes. And it pretty much does unless you want to compile for IE 11 or lower which causes some extra JavaScript code to be generated in the top of the file.This results in a failure in two if statements. The comment will be added to the previous node if the removed node doesn't have a next node or to the next node if it doesn't have a previous node. If it has both a previous and a next node, then the comment is simply discarded.