Implement setPublicClassFields and privateFieldsAsProperties assumptions
#12497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
24 tasks
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37890/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2fce14d:
|
JLHwung
reviewed
Dec 14, 2020
| // TODO(Babel 8): Remove the default falue | ||
| api = { assumption: () => {} }, | ||
| }) { | ||
| const setPublicClassFields = api.assumption("setPublicClassFields"); |
Contributor
There was a problem hiding this comment.
This will throw on @babel/core 7.12 + @babel/plugin-class-properties 7.13 because api is defined but api.assumption is not provided.
Never mind, I always forget the fact that api.assumption has been provided by helper plugin utils.
JLHwung
reviewed
Dec 14, 2020
JLHwung
previously approved these changes
Dec 14, 2020
Member
Author
|
The CI failure caught an assumption I didn't notice while writing the RFC. The class B {
method() { alert("B!"); }
}
class C {
method() { alert("C!"); }
}
class A extends B {
run() { super.method(); }
}
Object.setPrototypeOf(A.prototype, C.prototype);
new A().run();For this reason, we compile However, in loose mode we assume that it's never mutated and thus we compile it to I'm going to add this to the RFC. |
JLHwung
reviewed
Dec 14, 2020
| path, | ||
| privateNamesMap, | ||
| loose, | ||
| privateFieldsAsProperties, |
Contributor
There was a problem hiding this comment.
Consider change the signature to { privateFieldsAsProperties: boolean } so we can pass noDocumentAll later. This function is not a public interface so it should be okay.
nicolo-ribaudo
force-pushed
the
assumption/class-features
branch
from
1864522 to
98ad298
Compare
JLHwung
approved these changes
Dec 15, 2020
ExE-Boss
reviewed
Dec 16, 2020
nicolo-ribaudo
force-pushed
the
assumption/class-features
branch
2 times, most recently
from
dac1080 to
63e45fe
Compare
nicolo-ribaudo
force-pushed
the
feat-7.13.0/babel-core-features
branch
from
63c7a5a to
caa4fda
Compare
nicolo-ribaudo
force-pushed
the
assumption/class-features
branch
from
63e45fe to
2fce14d
Compare
hzoo
approved these changes
Jan 23, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 4, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 10, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 11, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 21, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408) - `setClassMethods` (#12407) - `setComputedProperties` (#12490) - `ignoreFunctionLength` (#12491) - `noDocumentAll` (#12481) - `iterableIsArray` and `arrayLikeIsIterable` (#12489) - `pureGetters` (#12504) - `skipForOfIteratorClosing` (#12496) - `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505) - `noNewArrows` (#12613, #12793) - `setPublicClassFields` and `privateFieldsAsProperties` (#12497) - `constantReexports` and `enumerableModuleMeta` (#12618) - `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726) Co-authored-by: Justin Ridgewell <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR: #12219
RFC: babel/rfcs#5
I also introduced a warning when both
looseandsetPublicClassFields/privateFieldsAsPropertiesare set (while still maintianing the fallback behavior we have for the other assumptions).This is because
loosesupport for these class features plugins is a mess and easily breaks: it was what initially lead me to theassumptionsRFC. We should encourage users to fully migrate toassumptionsfor these plugins when they start using them, to avoid other possible configuration conflicts caused by the implicit dependencies between them.The tests are what we already had for
loose.