[babel 8] Enable allowDeclareFields option by default with TS#12461
Merged
nicolo-ribaudo merged 4 commits intoJan 8, 2021
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37006/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e087d68:
|
hzoo
approved these changes
Dec 9, 2020
hzoo
left a comment
hzoo
left a comment
Member
There was a problem hiding this comment.
Confused myself since enabling by default "allowDeclareFields" also includes removing the option 😂
nicolo-ribaudo
changed the title
allowDeclareFields option by default with TSallowDeclareFields the default behavior with TS
nicolo-ribaudo
changed the title
allowDeclareFields the default behavior with TSallowDeclareFields option by default with TS
Member
Author
|
It's hard to write a PR title short enough that it fits in a commit header message 😛 |
JLHwung
approved these changes
Jan 7, 2021
nicolo-ribaudo
force-pushed
the
backport-ts-keep-class-fields
branch
from
January 7, 2021 21:35
cfe7dde to
1119524
Compare
nicolo-ribaudo
force-pushed
the
backport-ts-keep-class-fields
branch
6 times, most recently
from
January 7, 2021 23:29
da7cf92 to
cad1659
Compare
nicolo-ribaudo
force-pushed
the
backport-ts-keep-class-fields
branch
from
January 8, 2021 00:01
cad1659 to
e087d68
Compare
github-actions
Bot
added
the
outdated
nicolo-ribaudo
added
babel 8
PR: Breaking Change 💥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11114, same as #12457 but for TS.
Please review with whitespace diff off