Skip to content

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 27, 2020

…ions

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
License MIT

Main PR: #12219
RFC: babel/rfcs#5

Affected plugins:

  • transform-template-literals

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bab261:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo/assumptions branch from 9b673e3 to da76ea2 Compare November 27, 2020 15:49
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumption/template-literals branch from 0ec7b4b to 3ef32c5 Compare November 27, 2020 15:49
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo/assumptions branch from da76ea2 to c12cc57 Compare November 27, 2020 15:52
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumption/template-literals branch from 3ef32c5 to 3b7743e Compare November 27, 2020 16:03
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 27, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34909/

const { loose } = options;

const ignoreToPrimitiveHint =
options.loose || api.assumption("ignoreToPrimitiveHint");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check || is different than #12407 (comment).

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo/assumptions branch from c12cc57 to 8affe9b Compare December 10, 2020 20:27
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumption/template-literals branch from 3b7743e to 78f5041 Compare December 10, 2020 23:05
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumption/template-literals branch from 78f5041 to 9bab261 Compare December 11, 2020 19:13
@nicolo-ribaudo nicolo-ribaudo changed the base branch from nicolo-ribaudo/assumptions to feat-7.13.0/babel-core-features December 11, 2020 19:14
@nicolo-ribaudo nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Dec 11, 2020
@nicolo-ribaudo nicolo-ribaudo changed the title Implement mutableTemplateObject and ignoreToPrimitiveHint assumptions Implement mutableTemplateObject and ignoreToPrimitiveHint Dec 11, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit c09aa1b into babel:feat-7.13.0/babel-core-features Dec 11, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the assumption/template-literals branch December 11, 2020 19:28
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jan 12, 2021
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Feb 4, 2021
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Feb 10, 2021
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Feb 11, 2021
nicolo-ribaudo added a commit that referenced this pull request Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408)
- `setClassMethods` (#12407)
- `setComputedProperties` (#12490)
- `ignoreFunctionLength` (#12491)
- `noDocumentAll` (#12481)
- `iterableIsArray` and `arrayLikeIsIterable` (#12489)
- `pureGetters` (#12504)
- `skipForOfIteratorClosing` (#12496)
- `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505)
- `noNewArrows` (#12613, #12793)
- `setPublicClassFields` and `privateFieldsAsProperties` (#12497)
- `constantReexports` and `enumerableModuleMeta` (#12618)
- `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726)

Co-authored-by: Justin Ridgewell <[email protected]>
Co-authored-by: Huáng Jùnliàng <[email protected]>
nicolo-ribaudo added a commit that referenced this pull request Feb 16, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408)
- `setClassMethods` (#12407)
- `setComputedProperties` (#12490)
- `ignoreFunctionLength` (#12491)
- `noDocumentAll` (#12481)
- `iterableIsArray` and `arrayLikeIsIterable` (#12489)
- `pureGetters` (#12504)
- `skipForOfIteratorClosing` (#12496)
- `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505)
- `noNewArrows` (#12613, #12793)
- `setPublicClassFields` and `privateFieldsAsProperties` (#12497)
- `constantReexports` and `enumerableModuleMeta` (#12618)
- `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726)

Co-authored-by: Justin Ridgewell <[email protected]>
Co-authored-by: Huáng Jùnliàng <[email protected]>
nicolo-ribaudo added a commit that referenced this pull request Feb 21, 2021
- `mutableTemplateObject` and `ignoreToPrimitiveHint` (#12408)
- `setClassMethods` (#12407)
- `setComputedProperties` (#12490)
- `ignoreFunctionLength` (#12491)
- `noDocumentAll` (#12481)
- `iterableIsArray` and `arrayLikeIsIterable` (#12489)
- `pureGetters` (#12504)
- `skipForOfIteratorClosing` (#12496)
- `objectRestNoSymbols`, `setSpreadProperties` and `pureGetters` (#12505)
- `noNewArrows` (#12613, #12793)
- `setPublicClassFields` and `privateFieldsAsProperties` (#12497)
- `constantReexports` and `enumerableModuleMeta` (#12618)
- `constantSuper`, `superIsCallableConstructor` and `noClassCalls` (#12726)

Co-authored-by: Justin Ridgewell <[email protected]>
Co-authored-by: Huáng Jùnliàng <[email protected]>
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: assumptions outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants