Skip to content

[babel 8] Remove the Noop node type#12361

Merged
nicolo-ribaudo merged 4 commits into
babel:mainfrom
sidntrivedi:12355-remove-noop-node
Feb 21, 2021
Merged

[babel 8] Remove the Noop node type#12361
nicolo-ribaudo merged 4 commits into
babel:mainfrom
sidntrivedi:12355-remove-noop-node

Conversation

@sidntrivedi
Copy link
Copy Markdown
Contributor

@sidntrivedi sidntrivedi commented Nov 15, 2020 •
edited by JLHwung
Loading

Q                       A
Fixed Issues? Fixes #12355
Patch: Bug Fix?
Major: Breaking Change? Yes, behind BABEL_8_BREAKING
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2765
Any Dependency Changes?
License MIT

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Nov 15, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b85edce:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Nov 15, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41433/

@sidntrivedi
Copy link
Copy Markdown
Contributor Author

sidntrivedi commented Nov 23, 2020

@nicolo-ribaudo Please review if the changes look good. I am not sure why the CI is failing though.

@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented Nov 26, 2020

@sidntrivedi012 Please run make build and commit the changes in @babel/types.

@xtuc
Copy link
Copy Markdown
Member

xtuc commented Dec 8, 2020 •
edited
Loading

@sidntrivedi012 could you please resolve the merge conflict? Rebasing and Regenerating the file should do it

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Dec 8, 2020

Actually, #12431 will introduced other conflicts. Since this PR has lower priority (because we have time for Babel 8), maybe it's worth waiting for #12431 to be merged before rebasing this one.

@nicolo-ribaudo nicolo-ribaudo changed the base branch from next-8-dev to main February 21, 2021 00:08
@nicolo-ribaudo nicolo-ribaudo changed the title Remove the Noop node from babel type definition [babel 8] Remove the Noop node type Feb 21, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 507ad63 into babel:main Feb 21, 2021
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 24, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 24, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023
@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xtuc xtuc xtuc approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

v8.0.0

Development

Successfully merging this pull request may close these issues.

Remove Noop node from @babel/types

5 participants

@sidntrivedi @babel-bot @JLHwung @xtuc @nicolo-ribaudo