Add @babel/core support for the new assumptions option
#12219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
nicolo-ribaudo
commented
Oct 19, 2020
| /** | ||
| * Load a generic plugin/preset from the given descriptor loaded from the config object. | ||
| */ | ||
| const loadDescriptor = makeWeakCache(function* ( |
Member
Author
There was a problem hiding this comment.
When reviewing this file, turn off whitespace diff
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34632/ |
nicolo-ribaudo
force-pushed
the
assumptions
branch
from
4c025f5 to
ff20f60
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8affe9b:
|
nicolo-ribaudo
force-pushed
the
nicolo-ribaudo/targets-in-core
branch
from
a196b73 to
46dae56
Compare
nicolo-ribaudo
force-pushed
the
nicolo-ribaudo/targets-in-core
branch
2 times, most recently
from
58a1e84 to
1f501e0
Compare
nicolo-ribaudo
force-pushed
the
assumptions
branch
from
ff20f60 to
8f16324
Compare
nicolo-ribaudo
force-pushed
the
nicolo-ribaudo/targets-in-core
branch
from
1f501e0 to
7f6a7d8
Compare
nicolo-ribaudo
force-pushed
the
assumptions
branch
3 times, most recently
from
3d44f35 to
9aaf0da
Compare
nicolo-ribaudo
force-pushed
the
assumptions
branch
2 times, most recently
from
985ccbf to
9b673e3
Compare
nicolo-ribaudo
force-pushed
the
assumptions
branch
2 times, most recently
from
da76ea2 to
c12cc57
Compare
nicolo-ribaudo
force-pushed
the
nicolo-ribaudo/targets-in-core
branch
from
085be04 to
7bb7925
Compare
24 tasks
so that it doesn't override assumptions
nicolo-ribaudo
force-pushed
the
assumptions
branch
from
4fe074b to
8affe9b
Compare
nicolo-ribaudo
changed the base branch from
nicolo-ribaudo/targets-in-core
to
feat-7.13.0/babel-core-features
This was referenced Dec 11, 2020
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 12, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Jan 24, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 4, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 10, 2021
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Feb 11, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 16, 2021
- Disallow setting assumptions to `false` in presets (#12498)
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 21, 2021
- Disallow setting assumptions to `false` in presets (#12498)
This was referenced Mar 6, 2021
Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only introduces support for the
assumptionsoption in@babel/core. I will make plugins check it in separate PRs, otherwise this one would be too big to be properly reviewed.Assumptions implementation:
setClassMethods: ImplementsetClassMethodsassumption #12407mutableTemplateObject,ignoreToPrimitiveHint: ImplementmutableTemplateObjectandignoreToPrimitiveHint#12408Those PRs can be reviewed one by one (you can even review those PRs before this one), and I'll merge them here after that both this PR and the specific implementation PR have been approved.