Skip to content

Revert #12014 - #12027

Merged
JLHwung merged 2 commits into
babel:mainfrom
JLHwung:fix-12025
Sep 1, 2020
Merged

JLHwung merged 2 commits into
babel:mainfrom
JLHwung:fix-12025

Conversation

@JLHwung

@JLHwung JLHwung commented Sep 1, 2020 •

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #12025
Patch: Bug Fix? Yes
Any Dependency Changes? source-map is downgraded
License MIT

Revert #12014 where [email protected] includes mozilla/source-map#265 that throws when there is JS comments in the input code. Before mozilla/source-map#385 is resolved, we have to pin the source-map versions.

@JLHwung JLHwung added i: regression pkg: core PR: Revert ↩️ A type of pull request used for our changelog categories labels Sep 1, 2020
@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28210/

@codesandbox-ci

codesandbox-ci Bot commented Sep 1, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f331935:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung
JLHwung merged commit a91fdeb into babel:main Sep 1, 2020
@JLHwung
JLHwung deleted the fix-12025 branch September 1, 2020 19:42
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 2, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Revert ↩️ A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Error: original.line and original.column are not numbers" after upgrading to 7.11.5

4 participants