Skip to content

Conversation

@rricard
Copy link
Contributor

@rricard rricard commented Sep 26, 2019

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@rricard
Copy link
Contributor Author

rricard commented Sep 26, 2019

  • Revert back full build and hold
  • run test262 against the built version of babel in the repo

@buildsize
Copy link

buildsize bot commented Sep 27, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.69 MB [deleted]
babel-preset-env.min.js 1.63 MB [deleted]
babel.js 2.9 MB [deleted]
babel.min.js 1.6 MB [deleted]
test262.tap [new file] 110.87 KB

This introduces a second Circle CI pipeline that can optionally run
test262 against babel if the maintainers wish to do it before merging a
pull request. Running test262 is expensive so we don't want that to
happen for each commit in every PR.
@rricard
Copy link
Contributor Author

rricard commented Oct 6, 2019

Nice, the test output is not super useful yet but we might be able to do something out of the xunit file for further analysis.

@jbhoosreddy
Copy link
Contributor

@rricard yes but I don't want to run test262 twice for master and PR. Ideally we should be able to reuse the build artifact from master to compare and analyse.

It already takes 1.5 hours to run the tests once.

I am hoping @circleci can highlight new errors from existing errors like Jenkins can simply by giving it an xunit file

@jbhoosreddy
Copy link
Contributor

test262.tap [new file] 110.87 KB

This doesn't get added to babel build somehow, right? Or I need to add it in .npmignore or something?

@nicolo-ribaudo
Copy link
Member

This doesn't get added to babel build somehow, right?

No, because it isn't committed to the repo or present in our local copies.

@jbhoosreddy
Copy link
Contributor

So I put a support ticket to @circleci and turns out they do not have the Jenkins-style rendering of new vs existing test failures.
Please vote for: https://ideas.circleci.com/ideas/CCI-I-1192
If you find it relevant.

In the meanwhile, we may have to do this:

“ And also, we can store the previous test results data as artifacts and it can download via API, so I think you can also create a script that compares the test results.”

For CI, I think if we can highlight if a PR has failed new tests. But in terms of a web UI or anything fancy we should work on getting it added to test262.report

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants