Improve rightBrace position with retainLines #10390
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on
flow2typescriptand trying to match the input source code as best as I can. I'm using theretainLinesfeature to position the comments accurately. This works great, for the most part, but there's a number of issues with closing braces and brackets appearing on the previous line.This PR uses the
withSourcehelper to allow the printer to "catch up" for the closing brace in many cases. I've added a test for this; here's the test result without the changes:Note how this makes it look as if there are deliberate newlines in various places where there wasn't in the input code.