add assertShape to validate templateElement#10198
Merged
nicolo-ribaudo merged 3 commits intoJul 14, 2019
Merged
Conversation
tanhauhau
force-pushed
the
tanhauhau/validate-template-element
branch
from
July 11, 2019 15:10
0342134 to
5dc839d
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11119/ |
Member
|
If you run |
Member
Author
|
yup // index.js.flow
declare function templateElement(value: {raw:string, cooked:string}, tail?: boolean): BabelNodeTemplateElement;
// index.d.ts
export function templateElement(value: {raw:string, cooked:string}, tail?: boolean): TemplateElement; |
Co-Authored-By: Nicolò Ribaudo <[email protected]>
jridgewell
requested changes
Jul 12, 2019
existentialism
added
pkg: types
PR: Bug Fix 🐛
jridgewell
approved these changes
Jul 14, 2019
nicolo-ribaudo
approved these changes
Jul 14, 2019
AdamRamberg
pushed a commit
to AdamRamberg/babel
that referenced
this pull request
Jul 17, 2019
* add assertShape to validate templateElement * Update packages/babel-types/src/definitions/utils.js Co-Authored-By: Nicolò Ribaudo <[email protected]> * templateElement optional cooked
lock
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we update the
templateElement's validator and update the docs as well?@sebmck need your advice, because i saw you left a
TODOthere.