Skip to content

fix: custom instOfHandler result should be cast to boolean#10197

Merged
nicolo-ribaudo merged 1 commit into
babel:masterfrom
JLHwung:to-boolean-inst-of-handler
Jul 10, 2019
Merged

fix: custom instOfHandler result should be cast to boolean#10197
nicolo-ribaudo merged 1 commit into
babel:masterfrom
JLHwung:to-boolean-inst-of-handler

Conversation

@JLHwung

@JLHwung JLHwung commented Jul 10, 2019

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #10196
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Please refer to #10196 for the background and rationale.

@babel-bot

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11099/

@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jul 10, 2019
@nicolo-ribaudo
nicolo-ribaudo merged commit e88a569 into babel:master Jul 10, 2019
@nicolo-ribaudo

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

helper.instanceof does not cast [Symbol.hasInstance] call to boolean

5 participants