Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid code emitted for computed properties #8882

Closed
Neuroboy23 opened this issue Oct 16, 2018 · 2 comments · Fixed by #10029
Closed

Invalid code emitted for computed properties #8882

Neuroboy23 opened this issue Oct 16, 2018 · 2 comments · Fixed by #10029
Labels
Has PR outdated A closed issue/PR that is archived due to age. Recommended to make a new issue Spec: Class Fields

Comments

@Neuroboy23
Copy link

Neuroboy23 commented Oct 16, 2018 •
edited
Loading

I am working with other developers to bring private fields into TypeScript. While working on that, @joeywatts discovered this issue that currently exists in TypeScript. While comparing TS with Babel, we discovered a bug in Babel's handling of this. Given the input code from the link above, the Babel transformation produces code with a syntax error.

Input code:

const classes = [];
for (let i = 0; i <= 10; ++i) {
  classes.push(
    class A {
      [i] = "my property";
    }
  );
}

Snippet from Babel transformation:

var classes = [];
for (var i = 0; i <= 10; ++i) {
  var _class, _temp;
  classes.push(var _i = i;, (_temp = _class = function A() { // syntax error at `var` and `;`
    _classCallCheck(this, A);
    _defineProperty(this, _i, "my property");
  }, _temp));
}
@babel-bot
Copy link
Collaborator

Hey @Neuroboy23! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@joeywatts
Copy link

/cc @jridgewell

@tanhauhau tanhauhau mentioned this issue May 26, 2019
Merged
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Has PR outdated A closed issue/PR that is archived due to age. Recommended to make a new issue Spec: Class Fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed computed keys for class expression tanhauhau/babel
4 participants
@joeywatts @nicolo-ribaudo @Neuroboy23 @babel-bot