Skip to content

Commit e80c9ac

Browse files
authored
build: do not emit sourcemap in production build (#18231)
1 parent 8b01fec commit e80c9ac

3 files changed

Lines changed: 26 additions & 34 deletions

File tree

‎Gulpfile.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ if (process.env.CIRCLE_PR_NUMBER) {
331331
const babelVersion =
332332
require("./packages/babel-core/package.json").version + versionSuffix;
333333
function buildRollup(packages: PackageInfo[], buildStandalone?: boolean) {
334-
const sourcemap = process.env.NODE_ENV === "production";
335334
return Promise.all(
336335
packages.map(
337336
async ({
@@ -579,7 +578,6 @@ function buildRollup(packages: PackageInfo[], buildStandalone?: boolean) {
579578
}),
580579
buildStandalone &&
581580
rollupPolyfillNode({
582-
sourceMap: sourcemap,
583581
include: "**/*.{js,mjs,cjs,ts}",
584582
}),
585583
// https://github.com/babel/babel/issues/14301
@@ -607,7 +605,6 @@ function buildRollup(packages: PackageInfo[], buildStandalone?: boolean) {
607605
format,
608606
importAttributesKey: "with",
609607
name,
610-
sourcemap: sourcemap,
611608
exports: "named",
612609
interop(id) {
613610
if (!id) return "default";
@@ -665,7 +662,6 @@ function buildRollup(packages: PackageInfo[], buildStandalone?: boolean) {
665662
esModule: true,
666663
interop: "compat",
667664
name,
668-
sourcemap: sourcemap,
669665
exports: "named",
670666
plugins: [
671667
rollupTerser({

‎babel-worker.ts‎

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export async function transform(src: string, dest: string, opts: any = {}) {
3434
}
3535
log(`Compiling '${styleText("cyan", src)}'...`);
3636
const content = readFileSync(src, { encoding: "utf8" });
37-
const { code, map } = (await transformAsync(content, {
37+
const { code } = (await transformAsync(content, {
3838
filename: src,
3939
sourceFileName: path.relative(path.dirname(dest), src),
4040
caller: {
@@ -45,18 +45,7 @@ export async function transform(src: string, dest: string, opts: any = {}) {
4545
...opts,
4646
}))!;
4747

48-
if (map) {
49-
writeFileSync(
50-
dest,
51-
`${code}
52-
53-
//# sourceMappingURL=${path.basename(dest)}.map
54-
`,
55-
"utf8"
56-
);
57-
writeFileSync(dest + ".map", JSON.stringify(map), "utf8");
58-
} else {
59-
// @ts-expect-error code must not be for our project source
48+
if (code) {
6049
writeFileSync(dest, code, "utf8");
6150
}
6251
}

‎packages/babel-core/test/errors-stacks.js‎

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ function expectError(run) {
3636
// Replace line/column numbers, since they are affected by how
3737
// the code is compiled. The first optional ?\d+ is added by Jest.
3838
stack = stack.replace(/(?:\?\d+)?:\d+:\d+(\)?)$/gm, ":_:_$1");
39+
// Replace babel-core internal paths, since they are affected by the bundler
40+
// Development mode (babel-cli): <CWD>/packages/babel-core/lib/parse.js
41+
// Production mode (rollup): <CWD>/packages/babel-core/lib/index-shared.js
42+
stack = stack.replaceAll(
43+
/<CWD>\/packages\/babel-core\/lib\/[^:]+/g,
44+
"<BABEL_CORE_LIB_SOME_FILE>",
45+
);
3946

4047
// expectError is a customized expect wrapper
4148
// eslint-disable-next-line jest/valid-expect
@@ -55,7 +62,7 @@ describe("@babel/core errors", function () {
5562
}).toMatchInlineSnapshot(`
5663
"Error: Error inside config!
5764
at myConfig (<CWD>/packages/babel-core/test/fixtures/errors/error-config-function/babel.config.js:_:_)
58-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
65+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
5966
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
6067
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
6168
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -73,7 +80,7 @@ describe("@babel/core errors", function () {
7380
at f (<CWD>/packages/babel-core/test/fixtures/errors/error-config-function-more-frames/babel.config.js:_:_)
7481
at g (<CWD>/packages/babel-core/test/fixtures/errors/error-config-function-more-frames/babel.config.js:_:_)
7582
at myConfig (<CWD>/packages/babel-core/test/fixtures/errors/error-config-function-more-frames/babel.config.js:_:_)
76-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
83+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
7784
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
7885
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
7986
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -90,7 +97,7 @@ describe("@babel/core errors", function () {
9097
"Error: Error inside config!
9198
at Object.<anonymous> (<CWD>/packages/babel-core/test/fixtures/errors/error-config-file/babel.config.js:_:_)
9299
at require (... internal node frames ...)
93-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
100+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
94101
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
95102
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
96103
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -109,7 +116,7 @@ describe("@babel/core errors", function () {
109116
at g (<CWD>/packages/babel-core/test/fixtures/errors/error-config-file-more-frames/babel.config.js:_:_)
110117
at Object.<anonymous> (<CWD>/packages/babel-core/test/fixtures/errors/error-config-file-more-frames/babel.config.js:_:_)
111118
at require (... internal node frames ...)
112-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
119+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
113120
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
114121
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
115122
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -125,7 +132,7 @@ describe("@babel/core errors", function () {
125132
}).toMatchInlineSnapshot(`
126133
"Error: Error while parsing config - JSON5: invalid character '}' at 3:1
127134
at <CWD>/packages/babel-core/test/fixtures/errors/invalid-json/babel.config.json
128-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
135+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
129136
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
130137
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
131138
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -141,7 +148,7 @@ describe("@babel/core errors", function () {
141148
}).toMatchInlineSnapshot(`
142149
"Error: Configuration contains string/RegExp pattern, but no filename was passed to Babel
143150
at <CWD>/packages/babel-core/test/fixtures/errors/use-exclude/babel.config.js
144-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
151+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
145152
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
146153
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
147154
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -157,7 +164,7 @@ describe("@babel/core errors", function () {
157164
});
158165
}).toMatchInlineSnapshot(`
159166
"Error: Configuration contains string/RegExp pattern, but no filename was passed to Babel
160-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
167+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
161168
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
162169
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
163170
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -176,7 +183,7 @@ describe("@babel/core errors", function () {
176183
babel.transformSync(code, { filename: 'file.ts', presets: [/* your preset */] });
177184
\`\`\`
178185
See https://babeljs.io/docs/en/options#filename for more information.
179-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
186+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
180187
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
181188
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
182189
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -192,7 +199,7 @@ describe("@babel/core errors", function () {
192199
}).toMatchInlineSnapshot(`
193200
"Error: .sourceType must be "module", "commonjs", "script", "unambiguous", or undefined
194201
at <CWD>/packages/babel-core/test/fixtures/errors/invalid-option/babel.config.json
195-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
202+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
196203
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
197204
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
198205
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -208,7 +215,7 @@ describe("@babel/core errors", function () {
208215
}),
209216
).toMatchInlineSnapshot(`
210217
"Error: .sourceType must be "module", "commonjs", "script", "unambiguous", or undefined
211-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
218+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
212219
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
213220
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
214221
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
@@ -232,20 +239,20 @@ describe("@babel/core errors", function () {
232239
}).toMatchInlineSnapshot(`
233240
"Error: Internal error! This is a fake bug :)
234241
at Array.map (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
235-
at loadOneConfig (<CWD>/packages/babel-core/src/config/files/configuration.ts:_:_)
242+
at loadOneConfig (<BABEL_CORE_LIB_SOME_FILE>:_:_)
236243
at loadOneConfig.next (<anonymous>)
237-
at buildRootChain (<CWD>/packages/babel-core/src/config/config-chain.ts:_:_)
244+
at buildRootChain (<BABEL_CORE_LIB_SOME_FILE>:_:_)
238245
at buildRootChain.next (<anonymous>)
239-
at loadPrivatePartialConfig (<CWD>/packages/babel-core/src/config/partial.ts:_:_)
246+
at loadPrivatePartialConfig (<BABEL_CORE_LIB_SOME_FILE>:_:_)
240247
at loadPrivatePartialConfig.next (<anonymous>)
241-
at loadFullConfig (<CWD>/packages/babel-core/src/config/full.ts:_:_)
248+
at loadFullConfig (<BABEL_CORE_LIB_SOME_FILE>:_:_)
242249
at loadFullConfig.next (<anonymous>)
243-
at parse (<CWD>/packages/babel-core/src/parse.ts:_:_)
250+
at parse (<BABEL_CORE_LIB_SOME_FILE>:_:_)
244251
at parse.next (<anonymous>)
245252
at evaluateSync (<CWD>/node_modules/gensync/index.js:_:_)
246253
at sync (<CWD>/node_modules/gensync/index.js:_:_)
247-
at stopHiding - secret - don't use this - v1 (<CWD>/packages/babel-core/src/errors/rewrite-stack-trace.ts:_:_)
248-
at Module.parseSync (<CWD>/packages/babel-core/src/parse.ts:_:_)
254+
at stopHiding - secret - don't use this - v1 (<BABEL_CORE_LIB_SOME_FILE>:_:_)
255+
at Module.parseSync (<BABEL_CORE_LIB_SOME_FILE>:_:_)
249256
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_
250257
at expectError (<CWD>/packages/babel-core/test/errors-stacks.js:_:_)
251258
at <CWD>/packages/babel-core/test/errors-stacks.js:_:_

0 commit comments

Comments
 (0)