Better message

nicolo-ribaudo · nicolo-ribaudo · commit cc1e1c9701b1 · 2020-05-29T21:32:44.000Z
diff --git a/packages/babel-helper-create-class-features-plugin/src/features.js b/packages/babel-helper-create-class-features-plugin/src/features.js
@@ -65,8 +65,9 @@ export function enableFeature(file, feature, loose) {
   }
 
   let resolvedLoose: void | true | false;
+  let higherPriorityPluginName: void | string;
 
-  for (const [mask] of featuresSameLoose) {
+  for (const [mask, name] of featuresSameLoose) {
     if (!hasFeature(file, mask)) continue;
 
     const loose = isLoose(file, mask);
@@ -81,6 +82,7 @@ export function enableFeature(file, feature, loose) {
       );
     } else {
       resolvedLoose = loose;
+      higherPriorityPluginName = name;
     }
   }
 
@@ -89,12 +91,14 @@ export function enableFeature(file, feature, loose) {
       if (hasFeature(file, mask) && isLoose(file, mask) !== resolvedLoose) {
         setLoose(file, mask, resolvedLoose);
         console.warn(
-          "'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, " +
-            "@babel/plugin-proposal-private-methods and " +
-            "@babel/plugin-proposal-private-property-in-object (when they are enabled).\n" +
-            `${name} has been set to \`"loose": ${!resolvedLoose}\` by @babel/preset-env, but it ` +
-            `will be handled with \`"loose": ${resolvedLoose}\` in order to be compatible with the ` +
-            "other class features plugins.",
+          `Though the "loose" option was set to "${!resolvedLoose}" in your @babel/preset-env ` +
+            `config, it will not be used for ${name} since the "loose" mode option was set to ` +
+            `"${resolvedLoose}" for ${higherPriorityPluginName}.\nThe "loose" option must be the ` +
+            `same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods ` +
+            `and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can ` +
+            `silence this warning by explicitly adding\n` +
+            `\t["${name}", { "loose": ${resolvedLoose} }]\n` +
+            `to the "plugins" section of your Babel config.`,
         );
       }
     }
diff --git a/packages/babel-preset-env/test/fixtures/loose-class-features-precedence/methods-loose-preset-not-loose/stderr.txt b/packages/babel-preset-env/test/fixtures/loose-class-features-precedence/methods-loose-preset-not-loose/stderr.txt
@@ -1,2 +1,4 @@
-'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).
-@babel/plugin-proposal-class-properties has been set to `"loose": false` by @babel/preset-env, but it will be handled with `"loose": true` in order to be compatible with the other class features plugins.
+Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-class-properties since the "loose" mode option was set to "true" for @babel/plugin-proposal-private-methods.
+The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
+	["@babel/plugin-proposal-class-properties", { "loose": true }]
+to the "plugins" section of your Babel config.
diff --git a/packages/babel-preset-env/test/fixtures/loose-class-features-precedence/properties-loose-preset-not-loose/stderr.txt b/packages/babel-preset-env/test/fixtures/loose-class-features-precedence/properties-loose-preset-not-loose/stderr.txt
@@ -1,2 +1,4 @@
-'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).
-@babel/plugin-proposal-private-methods has been set to `"loose": false` by @babel/preset-env, but it will be handled with `"loose": true` in order to be compatible with the other class features plugins.
+Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "true" for @babel/plugin-proposal-class-properties.
+The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
+	["@babel/plugin-proposal-private-methods", { "loose": true }]
+to the "plugins" section of your Babel config.
diff --git a/packages/babel-preset-env/test/fixtures/loose-class-features-precedence/properties-not-loose-preset-loose/stderr.txt b/packages/babel-preset-env/test/fixtures/loose-class-features-precedence/properties-not-loose-preset-loose/stderr.txt
@@ -1,2 +1,4 @@
-'loose' mode configuration must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled).
-@babel/plugin-proposal-private-methods has been set to `"loose": true` by @babel/preset-env, but it will be handled with `"loose": false` in order to be compatible with the other class features plugins.
+Though the "loose" option was set to "true" in your @babel/preset-env config, it will not be used for @babel/plugin-proposal-private-methods since the "loose" mode option was set to "false" for @babel/plugin-proposal-class-properties.
+The "loose" option must be the same for @babel/plugin-proposal-class-properties, @babel/plugin-proposal-private-methods and @babel/plugin-proposal-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
+	["@babel/plugin-proposal-private-methods", { "loose": false }]
+to the "plugins" section of your Babel config.
