refactor: replace deprecated String.prototype.substr() (#14377)

CommanderRoot · web-flow · commit cb74c3772ebf · 2022-03-21T08:43:09.000-05:00
diff --git a/packages/babel-core/src/config/printer.ts b/packages/babel-core/src/config/printer.ts
@@ -79,7 +79,7 @@ function descriptorToConfig(
       // If the unloaded descriptor is a function, i.e. `plugins: [ require("my-plugin") ]`,
       // we print the first 50 characters of the function source code and hopefully we can see
       // `name: 'my-plugin'` in the source
-      name = `[Function: ${d.value.toString().substr(0, 50)} ... ]`;
+      name = `[Function: ${d.value.toString().slice(0, 50)} ... ]`;
     }
   }
   if (name == null) {
diff --git a/packages/babel-highlight/src/index.ts b/packages/babel-highlight/src/index.ts
@@ -176,7 +176,7 @@ if (process.env.BABEL_8_BREAKING) {
 
       if (
         JSX_TAG.test(token.value) &&
-        (text[offset - 1] === "<" || text.substr(offset - 2, 2) == "</")
+        (text[offset - 1] === "<" || text.slice(offset - 2, offset) == "</")
       ) {
         return "jsxIdentifier";
       }
diff --git a/packages/babel-parser/src/tokenizer/index.js b/packages/babel-parser/src/tokenizer/index.js
@@ -1606,7 +1606,7 @@ export default class Tokenizer extends CommentsParser {
             -1,
           );
           const match = this.input
-            .substr(this.state.pos - 1, 3)
+            .slice(this.state.pos - 1, this.state.pos + 2)
             .match(/^[0-7]+/);
 
           // This is never null, because of the if condition above.
diff --git a/scripts/parser-tests/test262/index.js b/scripts/parser-tests/test262/index.js
@@ -170,7 +170,7 @@ const runner = new TestRunner({
 
     for await (const test of stream) {
       // strip test/
-      const fileName = test.file.substr(5);
+      const fileName = test.file.slice(5);
 
       if (ignoredTests.some(start => fileName.startsWith(start))) continue;
 

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ function descriptorToConfig(`
`79`	`79`	// If the unloaded descriptor is a function, i.e. `plugins: [ require("my-plugin") ]`,
`80`	`80`	`// we print the first 50 characters of the function source code and hopefully we can see`
`81`	`81`	// `name: 'my-plugin'` in the source
`82`		- name = `[Function: ${d.value.toString().substr(0, 50)} ... ]`;
	`82`	+ name = `[Function: ${d.value.toString().slice(0, 50)} ... ]`;
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`	`if (name == null) {`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ if (process.env.BABEL_8_BREAKING) {`
`176`	`176`
`177`	`177`	`if (`
`178`	`178`	`JSX_TAG.test(token.value) &&`
`179`		`- (text[offset - 1] === "<" \|\| text.substr(offset - 2, 2) == "</")`
	`179`	`+ (text[offset - 1] === "<" \|\| text.slice(offset - 2, offset) == "</")`
`180`	`180`	`) {`
`181`	`181`	`return "jsxIdentifier";`
`182`	`182`	`}`