Skip to content

Commit bf48fca

Browse files
Revert "throw a TypeError if identifier validation fails (#106… (#10650)
This reverts commit c7d8b8a.
1 parent f8eb290 commit bf48fca

3 files changed

Lines changed: 3 additions & 13 deletions

File tree

packages/babel-types/src/definitions/core.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// @flow
2-
import isIdentifierName from "../validators/isIdentifierName";
2+
import isValidIdentifier from "../validators/isValidIdentifier";
33

44
import {
55
BINARY_OPERATORS,
@@ -406,8 +406,8 @@ defineType("Identifier", {
406406
...patternLikeCommon,
407407
name: {
408408
validate: chain(function(node, key, val) {
409-
if (!isIdentifierName(val)) {
410-
throw new TypeError(`"${val}" is not a valid identifer name`);
409+
if (!isValidIdentifier(val)) {
410+
// throw new TypeError(`"${val}" is not a valid identifer name`);
411411
}
412412
}, assertValueType("string")),
413413
},

packages/babel-types/src/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ export {
109109
default as isValidES3Identifier,
110110
} from "./validators/isValidES3Identifier";
111111
export { default as isValidIdentifier } from "./validators/isValidIdentifier";
112-
export { default as isIdentifierName } from "./validators/isIdentifierName";
113112
export { default as isVar } from "./validators/isVar";
114113
export { default as matchesPattern } from "./validators/matchesPattern";
115114
export { default as validate } from "./validators/validate";

packages/babel-types/src/validators/isIdentifierName.js

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)