Analyze ClassAccessorProperty to prevent the no-undef rule (#16884)

victorenator · web-flow · commit 33d705e8df0e · 2024-10-12T18:12:09.000-04:00
* Analyze `ClassAccessorProperty` to prevent the `no-undef` rule

a.js:

```js
class A {
  accessor b;
}
```

Current and expected behavior:

```bash
npx eslint a.js
```

```
a.js
  2:11  error  'b' is not defined  no-undef

✖ 1 problem (1 error, 0 warnings)
```

* add class accessor tests

* fix typo in article
diff --git a/eslint/babel-eslint-parser/src/analyze-scope.cts b/eslint/babel-eslint-parser/src/analyze-scope.cts
@@ -187,6 +187,10 @@ class Referencer extends OriginalReferencer {
     this._visitClassProperty(node);
   }
 
+  ClassAccessorProperty(node: any) {
+    this._visitClassProperty(node);
+  }
+
   PropertyDefinition(node: any) {
     this._visitClassProperty(node);
   }
diff --git a/eslint/babel-eslint-tests/test/integration/eslint/verify.js b/eslint/babel-eslint-tests/test/integration/eslint/verify.js
@@ -1837,6 +1837,41 @@ describe("verify", () => {
       });
     });
 
+    describe("accessor declarations", () => {
+      it("should not be undefined", () => {
+        verifyAndAssertMessages(
+          `
+              class C {
+                accessor d = 1;
+              }
+          `,
+          { "no-undef": 1 },
+        );
+      });
+
+      it("should not be unused", () => {
+        verifyAndAssertMessages(
+          `
+              export class C {
+                accessor d = 1;
+              }
+          `,
+          { "no-unused-vars": 1 },
+        );
+      });
+
+      it("no-use-before-define allows referencing the class in an accessor", () => {
+        verifyAndAssertMessages(
+          `
+            class C {
+              accessor d = C.name;
+            }
+          `,
+          { "no-use-before-define": 1 },
+        );
+      });
+    });
+
     describe("private methods", () => {
       it("should not be undefined", () => {
         verifyAndAssertMessages(

Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,10 @@ class Referencer extends OriginalReferencer {`
`187`	`187`	`this._visitClassProperty(node);`
`188`	`188`	`}`
`189`	`189`
	`190`	`+ ClassAccessorProperty(node: any) {`
	`191`	`+ this._visitClassProperty(node);`
	`192`	`+ }`
	`193`	`+`
`190`	`194`	`PropertyDefinition(node: any) {`
`191`	`195`	`this._visitClassProperty(node);`
`192`	`196`	`}`