Skip to content

Commit 317e332

Browse files
JLHwungJLHwung
authored
Enforce node protocol import (#17207)
* enable prefer-node-protocol rule * prefer node protocol import * fix broken scripts * fix e2e-old-babel error * strip node: protocol for old node versions * update Makefile.mjs
1 parent 68ba495 commit 317e332

152 files changed

Lines changed: 402 additions & 284 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Gulpfile.mjs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import path from "path";
2-
import fs from "fs";
3-
import { cpus } from "os";
4-
import { createRequire } from "module";
5-
import { fileURLToPath } from "url";
6-
import { Transform as TransformStream } from "stream";
7-
import { callbackify } from "util";
1+
import path from "node:path";
2+
import fs from "node:fs";
3+
import { cpus } from "node:os";
4+
import { createRequire } from "node:module";
5+
import { fileURLToPath } from "node:url";
6+
import { Transform as TransformStream } from "node:stream";
7+
import { callbackify } from "node:util";
88
import colors from "picocolors";
99
import gulp from "gulp";
1010
import { rollup } from "rollup";

‎Makefile.mjs‎

Lines changed: 2 additions & 2 deletions
Large diffs are not rendered by default.

‎Makefile.source.mjs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import "shelljs/make.js";
2-
import path from "path";
2+
import path from "node:path";
33
import {
44
readFileSync,
55
writeFileSync,
66
readdirSync,
77
existsSync,
88
mkdirSync,
9-
} from "fs";
9+
} from "node:fs";
1010
import semver from "semver";
1111
import { execaSync } from "execa";
1212

‎babel-worker.cjs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const { transformAsync } = require("@babel/core");
2-
const { mkdirSync, statSync, readFileSync, writeFileSync } = require("fs");
3-
const path = require("path");
2+
const { mkdirSync, statSync, readFileSync, writeFileSync } = require("node:fs");
3+
const path = require("node:path");
44
const { log } = require("./scripts/utils/logger.cjs");
55
const colors = require("picocolors");
66

‎babel.config.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// NOTE: This file must be runnable on all Node.js version
2+
/* eslint-disable unicorn/prefer-node-protocol */
13
"use strict";
24

35
let jestSnapshot = false;
@@ -191,6 +193,7 @@ module.exports = function (api) {
191193
: null,
192194

193195
require("./scripts/babel-plugin-bit-decorator/plugin.cjs"),
196+
require("./scripts/babel-plugin-transform-node-protocol-import/plugin.cjs"),
194197
].filter(Boolean),
195198
overrides: [
196199
{

‎benchmark/babel-core/real-case-preset-env-flow-ast/babel-parser-expression.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import baseline from "@babel-baseline/core";
33
import current from "@babel/core";
44
import parser from "@babel-baseline/parser";
55
import { report } from "../../util.mjs";
6-
import { readFileSync } from "fs";
6+
import { readFileSync } from "node:fs";
77

88
const suite = new Benchmark.Suite();
99
const fixtureName = "babel-parser-expression.txt";

‎benchmark/babel-core/real-case-preset-env-typescript/babel-parser-tokenizer-index.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Benchmark from "benchmark";
2-
import { readFileSync } from "fs";
2+
import { readFileSync } from "node:fs";
33
import {
44
report,
55
currentCore,

‎benchmark/babel-core/real-case-ts-cjs/bench.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { readFileSync } from "fs";
1+
import { readFileSync } from "node:fs";
22
import {
33
currentCore,
44
baselineCore,

‎benchmark/babel-generator/real-case/jquery.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import baseline from "@babel-baseline/generator";
33
import current from "@babel/generator";
44
import parser from "@babel/parser";
55
import { report } from "../../util.mjs";
6-
import { readFileSync } from "fs";
6+
import { readFileSync } from "node:fs";
77

88
const suite = new Benchmark.Suite();
99

‎benchmark/babel-parser/real-case-ts/bench.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { copyFileSync, readFileSync, rmSync } from "fs";
1+
import { copyFileSync, readFileSync, rmSync } from "node:fs";
22
// eslint-disable-next-line import/no-extraneous-dependencies
33
import { commonJS } from "$repo-utils";
44
import { Benchmark } from "../../util.mjs";

0 commit comments

Comments
 (0)