Add eslint-plugin-regexp (#16680)

nicolo-ribaudo · web-flow · commit 2413d1a747db · 2024-07-29T17:42:43.000+02:00
diff --git a/Gulpfile.mjs b/Gulpfile.mjs
@@ -837,7 +837,7 @@ gulp.task("build-vendor", async () => {
       {
         // Remove the node: prefix from imports, so that it works in old Node.js version
         // TODO(Babel 8): This can be removed.
-        transform: code => code.replace(/(?<=from ["'"])node:/g, ""),
+        transform: code => code.replace(/(?<=from ["'])node:/g, ""),
       },
     ],
   });
diff --git a/Makefile.js b/Makefile.js
diff --git a/Makefile.source.mjs b/Makefile.source.mjs
@@ -36,7 +36,7 @@ function print(...msgs) {
   console.log.apply(console, msgs);
 }
 
-function exec(executable, args, cwd, inheritStdio = true) {
+function exec(executable, args, cwd, inheritStdio = true, noExit = false) {
   print(
     `${executable
       .replaceAll(YARN_PATH, "yarn")
@@ -56,15 +56,17 @@ function exec(executable, args, cwd, inheritStdio = true) {
           `\ncommand: ${executable} ${args.join(" ")}\ncode: ${error.exitCode}`
         )
       );
-      // eslint-disable-next-line no-process-exit
-      process.exit(error.exitCode);
+      if (!noExit) {
+        // eslint-disable-next-line no-process-exit
+        process.exit(error.exitCode);
+      }
     }
     throw error;
   }
 }
 
-function yarn(args, cwd, inheritStdio) {
-  return exec(YARN_PATH, args, cwd, inheritStdio);
+function yarn(args, cwd, inheritStdio, noExit) {
+  return exec(YARN_PATH, args, cwd, inheritStdio, noExit);
 }
 
 function node(args, cwd, inheritStdio) {
@@ -382,11 +384,25 @@ function eslint(...extraArgs) {
       NODE_OPTIONS: "--max-old-space-size=16384",
     });
   } else {
+    let err = null;
     for (const chunk of chunks) {
-      env(() => yarn(["eslint", ...chunk, ...eslintArgs]), {
-        BABEL_ENV: "test",
-      });
+      try {
+        env(
+          () =>
+            yarn(
+              ["eslint", ...chunk, ...eslintArgs],
+              undefined,
+              undefined,
+              true
+            ),
+          { BABEL_ENV: "test" }
+        );
+      } catch (e) {
+        err = e;
+      }
     }
+    // eslint-disable-next-line no-process-exit
+    if (err) process.exit(err.exitCode);
   }
 }
 
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -5,6 +5,7 @@ import configInternal from "@babel/eslint-config-internal";
 import pluginImport from "eslint-plugin-import";
 import pluginN from "eslint-plugin-n";
 import pluginPrettier from "eslint-plugin-prettier";
+import pluginRegexp from "eslint-plugin-regexp";
 import pluginBabelDevelopment from "@babel/eslint-plugin-development";
 import pluginBabelDevelopmentInternal from "@babel/eslint-plugin-development-internal";
 import typescriptEslint from "typescript-eslint";
@@ -33,6 +34,7 @@ const sourceFiles = exts => [
 
 export default [
   ...configInternal,
+  pluginRegexp.configs["flat/recommended"],
   {
     ignores: [
       "/lib",
@@ -76,6 +78,7 @@ export default [
     rules: {
       "prettier/prettier": "error",
       "import/no-extraneous-dependencies": "error",
+      "regexp/match-any": ["error", { allows: ["[^]", "dotAll"] }],
     },
   },
   ...typescriptEslint.config({
diff --git a/eslint/babel-eslint-plugin-development-internal/src/rules/report-error-message-format.cjs b/eslint/babel-eslint-plugin-development-internal/src/rules/report-error-message-format.cjs
@@ -1,6 +1,6 @@
 const messageId = "mustMatchPattern";
 
-const pattern = /(('.*')|(`.*`)|[A-Z]).*(\.|\?)$/s;
+const pattern = /(?:('|`)[^'`]*\1|[A-Z]).*[.?]$/s;
 
 module.exports = {
   meta: {
diff --git a/eslint/babel-eslint-plugin-development-internal/src/rules/require-default-import-fallback.cjs b/eslint/babel-eslint-plugin-development-internal/src/rules/require-default-import-fallback.cjs
@@ -21,9 +21,9 @@ module.exports = {
           // This will not become an ESM file.
           src.endsWith(".cjs") ||
           // @babel/core automatically unwraps .default from plugins/presets.
-          /^@babel\/(plugin|preset)-/.test(src) ||
+          /^@babel\/(?:plugin|preset)-/.test(src) ||
           (src.endsWith("./lib/index.js") &&
-            /babel-(plugin|preset)-/.test(filename))
+            /babel-(?:plugin|preset)-/.test(filename))
         ) {
           return;
         }
diff --git a/package.json b/package.json
@@ -59,6 +59,7 @@
     "eslint-plugin-jest": "^27.9.0",
     "eslint-plugin-n": "^17.9.0",
     "eslint-plugin-prettier": "^5.1.3",
+    "eslint-plugin-regexp": "^2.6.0",
     "execa": "^9.0.0",
     "glob": "^10.3.10",
     "gulp": "^5.0.0",
diff --git a/packages/babel-core/src/config/files/configuration.ts b/packages/babel-core/src/config/files/configuration.ts
@@ -188,7 +188,7 @@ const readIgnoreConfig = makeStaticFileCache((filepath, content) => {
   const ignoreDir = path.dirname(filepath);
   const ignorePatterns = content
     .split("\n")
-    .map<string>(line => line.replace(/#(.*?)$/, "").trim())
+    .map<string>(line => line.replace(/#.*$/, "").trim())
     .filter(line => !!line);
 
   for (const pattern of ignorePatterns) {
diff --git a/packages/babel-core/src/transformation/normalize-file.ts b/packages/babel-core/src/transformation/normalize-file.ts
@@ -17,7 +17,7 @@ const debug = buildDebug("babel:transform:file");
 // but without // or /* at the beginning of the comment.
 
 const INLINE_SOURCEMAP_REGEX =
-  /^[@#]\s+sourceMappingURL=data:(?:application|text)\/json;(?:charset[:=]\S+?;)?base64,(?:.*)$/;
+  /^[@#]\s+sourceMappingURL=data:(?:application|text)\/json;(?:charset[:=]\S+?;)?base64,.*$/;
 const EXTERNAL_SOURCEMAP_REGEX =
   /^[@#][ \t]+sourceMappingURL=([^\s'"`]+)[ \t]*$/;
 
diff --git a/packages/babel-core/test/errors-stacks.js b/packages/babel-core/test/errors-stacks.js
@@ -27,7 +27,7 @@ function expectError(run) {
     // visible when using --run-in-band, comes from inside jest but doesn't have an
     // associated file path.
     stack = stack.replace(
-      /(?:\n\s*at [^\n]+?node_modules\/(?:@?jest|tinypool|piscina)[^\n]+|\n\s*at async Promise.all[^\n]+)+/g,
+      /(?:\n\s*at (?:[^\n]+?node_modules\/(?:@?jest|tinypool|piscina)|\n\s*at async Promise.all)[^\n]+)+/g,
       "\n    at ... internal jest frames ...",
     );
     // Remove node internal frames, since they change by version
diff --git a/packages/babel-core/test/option-manager.js b/packages/babel-core/test/option-manager.js
@@ -89,7 +89,7 @@ describe("option-manager", () => {
           ],
         });
       }).toThrow(
-        /Duplicate plugin\/preset detected.*Duplicates detected are.*my-plugin.*my-plugin/ms,
+        /Duplicate plugin\/preset detected.*Duplicates detected are.*my-plugin.*my-plugin/s,
       );
       expect(calls).toEqual([]);
     });
diff --git a/packages/babel-helper-compilation-targets/src/utils.ts b/packages/babel-helper-compilation-targets/src/utils.ts
@@ -3,7 +3,8 @@ import { OptionValidator } from "@babel/helper-validator-option";
 import { unreleasedLabels } from "./targets.ts";
 import type { Target, Targets } from "./types.ts";
 
-const versionRegExp = /^(\d+|\d+.\d+)$/;
+const versionRegExp =
+  /^(?:\d+|\d(?:\d?[^\d\n\r\u2028\u2029]\d+|\d{2,}(?:[^\d\n\r\u2028\u2029]\d+)?))$/;
 
 const v = new OptionValidator(PACKAGE_JSON.name);
 
diff --git a/packages/babel-helper-create-regexp-features-plugin/src/util.ts b/packages/babel-helper-create-regexp-features-plugin/src/util.ts
@@ -56,7 +56,7 @@ export function canSkipRegexpu(
     if (options.unicodeFlag === "transform") return false;
     if (
       options.unicodePropertyEscapes === "transform" &&
-      /\\[pP]{/.test(pattern)
+      /\\p\{/i.test(pattern)
     ) {
       return false;
     }
diff --git a/packages/babel-helper-module-imports/test/index.js b/packages/babel-helper-module-imports/test/index.js
@@ -1189,9 +1189,7 @@ describe("@babel/helper-module-imports", () => {
             operation,
             input,
           );
-          expect(out.replace(/[\s\n]+/g, " ")).toBe(
-            expected.replace(/[\s\n]+/g, " "),
-          );
+          expect(out.replace(/\s+/g, " ")).toBe(expected.replace(/\s+/g, " "));
         },
       );
 
diff --git a/packages/babel-helper-module-transforms/src/get-module-name.ts b/packages/babel-helper-module-transforms/src/get-module-name.ts
@@ -64,7 +64,7 @@ export default function getModuleName(
       // remove sourceRoot from filename
       .replace(sourceRootReplacer, "")
       // remove extension
-      .replace(/\.(\w*?)$/, "");
+      .replace(/\.\w*$/, "");
   }
 
   // normalize path separators
diff --git a/packages/babel-helper-transform-fixture-test-runner/src/index.ts b/packages/babel-helper-transform-fixture-test-runner/src/index.ts
@@ -504,7 +504,7 @@ function normalizeOutput(
     // the output logs so that we don't have to duplicate all the debug fixtures for
     // the two different Babel versions.
     if (normalizePresetEnvDebug) {
-      result = result.replace(/(\s+)proposal-/gm, "$1transform-");
+      result = result.replace(/(\s+)proposal-/g, "$1transform-");
     }
 
     // For some reasons, in older Node.js versions some symlinks are not properly
diff --git a/packages/babel-parser/test/helpers/serialization.js b/packages/babel-parser/test/helpers/serialization.js
@@ -72,11 +72,11 @@ const toError = message =>
     ? Error(message.replace(ErrorPrefixRegExp, ""))
     : SyntaxError(message.replace(ErrorPrefixRegExp, ""));
 
-const LocRegExp = /"loc":(\s*\{(?:[^}{]+|\{(?:[^}{]+|\([^}{]*\})*\})*\})/gm;
-const StartEndRegExp = /("(start|end)":\s*(\d+),\s*){2}/gm;
+const LocRegExp = /"loc":(\s*\{(?:[^}{]|\{(?:[^}{(]|\([^}{]*\})*\})*\})/g;
+const StartEndRegExp = /("(start|end)":\s*(\d+),\s*){2}/g;
 const CompactRegExp = new RegExp(
   `${StartEndRegExp.source}${LocRegExp.source}`,
-  "gm",
+  "g",
 );
 
 export function serialize(value) {
@@ -95,7 +95,7 @@ export function serialize(value) {
   const serialized = stringify(value, encode, 2).replace(
     CompactRegExp,
     // This is safe since none of the values can have spaces in them.
-    string => string.replace(/\s+/gm, () => ""),
+    string => string.replace(/\s+/g, () => ""),
   );
 
   return [extended, serialized];
diff --git a/packages/babel-parser/test/helpers/to-fuzzed-options.js b/packages/babel-parser/test/helpers/to-fuzzed-options.js
@@ -26,7 +26,7 @@ const toAdjustFunction = adjustments =>
         adjustments,
       );
 
-const SyntaxErrorMessageRegExp = /\((\d+):(\d+)\)$/;
+const SyntaxErrorMessageRegExp = /\(\d+:\d+\)$/;
 const toAdjustedSyntaxError = (adjust, error) =>
   error && SyntaxErrorMessageRegExp.test(error.message)
     ? SyntaxError(
diff --git a/packages/babel-plugin-proposal-destructuring-private/test/util.skip-bundled.js b/packages/babel-plugin-proposal-destructuring-private/test/util.skip-bundled.js
@@ -4,7 +4,7 @@ import { traversePattern, privateKeyPathIterator } from "../lib/util.js";
 function wrapSourceInClassEnvironment(input) {
   const usedPrivateNames = new Set();
   let matched;
-  const re = /#[\w_]+/g;
+  const re = /#\w+/g;
   while ((matched = re.exec(input)) !== null) {
     usedPrivateNames.add(matched[0]);
   }
diff --git a/packages/babel-plugin-transform-flow-strip-types/src/index.ts b/packages/babel-plugin-transform-flow-strip-types/src/index.ts
@@ -10,7 +10,7 @@ export interface Options {
 export default declare((api, opts: Options) => {
   api.assertVersion(REQUIRED_VERSION(7));
 
-  const FLOW_DIRECTIVE = /(@flow(\s+(strict(-local)?|weak))?|@noflow)/;
+  const FLOW_DIRECTIVE = /@flow(?:\s+(?:strict(?:-local)?|weak))?|@noflow/;
 
   let skipStrip = false;
 
diff --git a/packages/babel-plugin-transform-literals/src/index.ts b/packages/babel-plugin-transform-literals/src/index.ts
@@ -18,7 +18,7 @@ export default declare(api => {
       StringLiteral({ node }) {
         // unicode escape
         // @ts-expect-error Add node.extra typings
-        if (node.extra && /\\[u]/gi.test(node.extra.raw)) {
+        if (node.extra && /\\u/i.test(node.extra.raw)) {
           node.extra = undefined;
         }
       },
diff --git a/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts b/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts
@@ -27,11 +27,11 @@ const DEFAULT = {
 };
 
 const JSX_SOURCE_ANNOTATION_REGEX =
-  /^\s*\*?\s*@jsxImportSource\s+([^\s]+)\s*$/m;
-const JSX_RUNTIME_ANNOTATION_REGEX = /^\s*\*?\s*@jsxRuntime\s+([^\s]+)\s*$/m;
+  /^\s*(?:\*\s*)?@jsxImportSource\s+(\S+)\s*$/m;
+const JSX_RUNTIME_ANNOTATION_REGEX = /^\s*(?:\*\s*)?@jsxRuntime\s+(\S+)\s*$/m;
 
-const JSX_ANNOTATION_REGEX = /^\s*\*?\s*@jsx\s+([^\s]+)\s*$/m;
-const JSX_FRAG_ANNOTATION_REGEX = /^\s*\*?\s*@jsxFrag\s+([^\s]+)\s*$/m;
+const JSX_ANNOTATION_REGEX = /^\s*(?:\*\s*)?@jsx\s+(\S+)\s*$/m;
+const JSX_FRAG_ANNOTATION_REGEX = /^\s*(?:\*\s*)?@jsxFrag\s+(\S+)\s*$/m;
 
 const get = (pass: PluginPass, name: string) =>
   pass.get(`@babel/plugin-react-jsx/${name}`);
diff --git a/packages/babel-plugin-transform-typescript/src/index.ts b/packages/babel-plugin-transform-typescript/src/index.ts
@@ -103,7 +103,7 @@ export default declare((api, opts: Options) => {
 
   api.assertVersion(REQUIRED_VERSION(7));
 
-  const JSX_PRAGMA_REGEX = /\*?\s*@jsx((?:Frag)?)\s+([^\s]+)/;
+  const JSX_PRAGMA_REGEX = /\*?\s*@jsx((?:Frag)?)\s+(\S+)/;
 
   const {
     allowNamespaces = true,
diff --git a/packages/babel-preset-env/src/index.ts b/packages/babel-preset-env/src/index.ts
@@ -101,7 +101,7 @@ const getPlugin = (pluginName: string) => {
 export const transformIncludesAndExcludes = (opts: Array<string>): any => {
   return opts.reduce(
     (result, opt) => {
-      const target = /^(es|es6|es7|esnext|web)\./.exec(opt)
+      const target = /^(?:es|es6|es7|esnext|web)\./.test(opt)
         ? "builtIns"
         : "plugins";
       result[target].add(opt);
diff --git a/packages/babel-preset-env/src/normalize-options.ts b/packages/babel-preset-env/src/normalize-options.ts
@@ -54,7 +54,7 @@ function flatMap<T, U>(array: Array<T>, fn: (item: T) => Array<U>): Array<U> {
 }
 
 export const normalizePluginName = (plugin: string) =>
-  plugin.replace(/^(@babel\/|babel-)(plugin-)?/, "");
+  plugin.replace(/^(?:@babel\/|babel-)(?:plugin-)?/, "");
 
 const expandIncludesAndExcludes = (
   filterList: PluginListOption = [],
diff --git a/packages/babel-traverse/src/scope/index.ts b/packages/babel-traverse/src/scope/index.ts
@@ -502,9 +502,7 @@ class Scope {
    */
 
   generateUid(name: string = "temp"): string {
-    name = toIdentifier(name)
-      .replace(/^_+/, "")
-      .replace(/[0-9]+$/g, "");
+    name = toIdentifier(name).replace(/^_+/, "").replace(/\d+$/g, "");
 
     let uid;
     let i = 1;
diff --git a/packages/babel-types/src/converters/valueToNode.ts b/packages/babel-types/src/converters/valueToNode.ts
@@ -104,7 +104,7 @@ function valueToNode(value: unknown): t.Expression {
   // regexes
   if (isRegExp(value)) {
     const pattern = value.source;
-    const flags = /\/([a-z]+|)$/.exec(value.toString())[1];
+    const flags = /\/([a-z]*)$/.exec(value.toString())[1];
     return regExpLiteral(pattern, flags);
   }
 
diff --git a/packages/babel-types/src/utils/react/cleanJSXElementLiteralChild.ts b/packages/babel-types/src/utils/react/cleanJSXElementLiteralChild.ts
@@ -30,12 +30,12 @@ export default function cleanJSXElementLiteralChild(
 
     // trim whitespace touching a newline
     if (!isFirstLine) {
-      trimmedLine = trimmedLine.replace(/^[ ]+/, "");
+      trimmedLine = trimmedLine.replace(/^ +/, "");
     }
 
     // trim whitespace touching an endline
     if (!isLastLine) {
-      trimmedLine = trimmedLine.replace(/[ ]+$/, "");
+      trimmedLine = trimmedLine.replace(/ +$/, "");
     }
 
     if (trimmedLine) {
diff --git a/packages/babel-types/test/converters.js b/packages/babel-types/test/converters.js
@@ -52,6 +52,7 @@ describe("converters", function () {
       expect(t.valueToNode(undefined)).toEqual(t.identifier("undefined"));
     });
     it("RegExp", function () {
+      // eslint-disable-next-line regexp/no-useless-flag
       expect(t.valueToNode(/abc.+/gm)).toEqual(t.regExpLiteral("abc.+", "gm"));
     });
     it("array", function () {
diff --git a/scripts/parser-tests/typescript/index.js b/scripts/parser-tests/typescript/index.js
@@ -50,7 +50,7 @@ function baselineContainsParserErrorCodes(testName) {
 }
 
 const IgnoreRegExp = /@noTypesAndSymbols|ts-ignore|\n#!/;
-const AlwaysStrictRegExp = /(^|\n)\/\/\s*@alwaysStrict:\s*true/;
+const AlwaysStrictRegExp = /^\/\/\s*@alwaysStrict:\s*true/m;
 
 const runner = new TestRunner({
   testDir: path.join(TSTestsPath, "./cases/compiler"),
@@ -83,8 +83,8 @@ function toFiles(strictMode, contents, name) {
     ])
     .filter(
       ([sourceFilename, contents]) =>
-        !/\.(css|js|json|md)$/.test(sourceFilename) &&
-        contents.split("\n").some(line => !/(^\s*$)|(^\/\/[^\n]*$)/.test(line))
+        !/\.(?:css|js|json|md)$/.test(sourceFilename) &&
+        contents.split("\n").some(line => !/^\s*$|^\/\/[^\n]*$/.test(line))
     )
     .map(([sourceFilename, contents]) => ({
       contents,
@@ -95,13 +95,13 @@ function toFiles(strictMode, contents, name) {
         ["typescript", { dts: sourceFilename.endsWith(".d.ts") }],
         "decorators-legacy",
         "importAssertions",
-        /\.(t|j)sx$/.test(sourceFilename) && "jsx",
+        /\.[tj]sx$/.test(sourceFilename) && "jsx",
       ].filter(plugin => !!plugin),
     }));
 }
 
 const BracketedFileRegExp = /\/\/\/\/\s*\[([^\]]+)\][^\n]*(\n|$)/;
-const AtFileRegExp = /(?:^|\n)\/\/\s*@filename:\s*([^\s]*)\s*(?:\n|$)/i;
+const AtFileRegExp = /(?:^|\n)\/\/\s*@filename:\s*(\S+)\s*(?:\n|$)/i;
 
 // Modified from: https://github.com/microsoft/TypeScript-Website/blob/v2/packages/ts-twoslasher/src/index.ts
 function splitTwoslashCodeInfoFiles(code, defaultFileName, root = "") {
@@ -116,9 +116,7 @@ function splitTwoslashCodeInfoFiles(code, defaultFileName, root = "") {
   for (const line of lines) {
     const newFileName = BracketedFileRegExp.test(line)
       ? line.match(BracketedFileRegExp)[1]
-      : AtFileRegExp.test(line)
-        ? line.match(AtFileRegExp)[1]
-        : false;
+      : line.match(AtFileRegExp)?.[1] ?? false;
     if (newFileName) {
       fileMap.push([root + nameForFile, currentFileContent]);
       nameForFile = newFileName;
diff --git a/scripts/rollup-plugin-babel-source.js b/scripts/rollup-plugin-babel-source.js
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -837,7 +837,7 @@ gulp.task("build-vendor", async () => {`
`837`	`837`	`{`
`838`	`838`	`// Remove the node: prefix from imports, so that it works in old Node.js version`
`839`	`839`	`// TODO(Babel 8): This can be removed.`
`840`		`- transform: code => code.replace(/(?<=from ["'"])node:/g, ""),`
	`840`	`+ transform: code => code.replace(/(?<=from ["'])node:/g, ""),`
`841`	`841`	`},`
`842`	`842`	`],`
`843`	`843`	`});`