Ability to evaluate single, query, or col of script tags.#93
Merged
borkdude merged 1 commit intobabashka:mainfrom Nov 23, 2024
Merged
Ability to evaluate single, query, or col of script tags.#93borkdude merged 1 commit intobabashka:mainfrom
borkdude merged 1 commit intobabashka:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional PR for #89 to address discussion here: #92
This adds the ability to pass either:
colof script tagsquerySelectorAll()of tags (NodeListor other JS array-like)into
scittle.core.eval_script_tags()and have it do the right thing.Tested like this (with hello.cljs and thing.cljs test scripts in the current dir):
Please answer the following questions and leave the below in as part of your PR.
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
(Update to #89 and discussion so doesn't need a new CHANGELOG.md line I think).