Support string requires of globalThis js deps #95#129
Merged
borkdude merged 2 commits intobabashka:mainfrom Aug 21, 2025
Merged
Support string requires of globalThis js deps #95#129borkdude merged 2 commits intobabashka:mainfrom
globalThis js deps #95#129borkdude merged 2 commits intobabashka:mainfrom
Conversation
Collaborator
Nice! I guess it's guaranteed that the type=module script tag always runs first? <html>
<head>
<script type="module">
import confetti from "https://esm.sh/[email protected]"
globalThis.x = await(Promise.resolve(1));
globalThis.JSConfetti = confetti;
</script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/scittle.js" type="application/javascript"></script>
<script type="application/x-scittle">
(js/console.log js/x)
(js/JSConfetti)
</script>
</head>
<body>
</body>
</html> |
Collaborator
|
Hmm, according to some sources (ChatGPT...) the type=module isn't guaranteed to finish before the "sync" script tag since it's always defer-ed by default |
Collaborator
|
Yeah here's a counter-example: <html>
<head>
<script type="module">
import confetti from "https://esm.sh/[email protected]"
globalThis.x = await(new Promise((resolve) => setTimeout(resolve, 500)));
console.log('hello')
globalThis.JSConfetti = confetti;
</script>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/scittle.js" type="application/javascript"></script>
<script type="application/x-scittle">
(js/console.log js/x)
(js/JSConfetti)
</script>
</head>
<body>
</body>
</html> |
Contributor
Author
|
Ah ok so it would only work for non-modules scripts. Maybe we could add something like |
Contributor
Author
|
Although I don't think onload would wait for the setTimeout await. 🤔 |
Collaborator
|
I think this should be the solution with async modules: <html>
<head>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/scittle.js" type="application/javascript"></script>
<script>scittle.core.disable_auto_eval()</script>
<script type="module">
import confetti from "https://esm.sh/[email protected]"
globalThis.x = await(new Promise((resolve) => setTimeout(resolve, 500)));
console.log('hello')
globalThis.JSConfetti = confetti;
scittle.core.eval_script_tags();
</script>
<script type="application/x-scittle">
(js/console.log js/x)
(js/JSConfetti)
</script>
</head>
<body>
</body>
</html> |
Collaborator
|
and this would work perfectly with your solution as well |
Collaborator
|
Exciting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95. This patch updates Scittle to support requiring already-loaded script tag JS deps off
globalThis. Workflow:You can also use esm imports in your index.html if you monkey-patch them onto
globalThis/windowbefore Scittle runs.I'm not sure my naïve implementation is future proof so don't hesitate to reject or ask for changes. On #95 we spoked about David's plan to give globalThis requires a special syntax, and this patch should be forwards compatible with any future syntax I think.
In future it could also be adapted to load es modules using maybe
sci.async. So it would try two loaders for a string require: 1. from globalThis 2. looking up the import map and doing an async esm import from the url specified. That's outside the scope of this PR though.Please answer the following questions and leave the below in as part of your PR.
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
I have updated the CHANGELOG.md file with a description of the addressed issue.