Fix FakeNavigationManager when navigating to Uri without absolute path.#952
Fix FakeNavigationManager when navigating to Uri without absolute path.#952linkdotnet merged 5 commits intobUnit-dev:mainfrom
Conversation
In the real implementation this works fine. But not when unit-testing. This fixes that issue.
|
Hey @joelmandell, thanks for reaching out to us and filing a PR for the issue you are encountering. Let me level here with you to find a common denominator. The issue you are seeing is solely because of umlauts in the URL not because they are relative or whatnot. If you remove the We just swallowed that exception which is why it gave the impression this behavior is more or less expected. Anyway back on track. I do think your change looks good. There is a smaller nitpick with the test - but I'll put the comment directly at the appropriate place. |
tests/bunit.web.tests/TestDoubles/NavigationManager/FakeNavigationManagerTest.cs
Outdated
Show resolved
Hide resolved
tests/bunit.web.tests/TestDoubles/NavigationManager/FakeNavigationManagerTest.cs
Outdated
Show resolved
Hide resolved
Fixes according to comments on PR.
|
Thanks @linkdotnet for your comments and I made changes according to them 👍 |
One small thing in the changelog.md and we are there! Great job so far! |
|
Perfect. Looking good and ready for Thanks again @joelmandell! |
2 participants
Fix FakeNavigationManager when navigating to Uri without absolute path.
Pull request description
I run some unit tests of a component today that navigates without problem to a path without absolute path.
But in unit test it throws. I did some unit test of bUnit and found out that FakeNavigationManager could not handle that case.
So this is a PR, that seems to fix it.
PR meta checklist
mainbranch for codeor targeted at
stablebranch for documentation that is live on bunit.dev.Code PR specific checklist