Skip to content

Conversation

@kaishin
Copy link

@kaishin kaishin commented May 29, 2014

I love MacVim, but I think the current icon is starting to show its age. I've designed this and used it locally for a while.

icon_512x512

@kaishin kaishin changed the title Added new OS X icon New icon May 29, 2014
@kaishin
Copy link
Author

kaishin commented May 29, 2014

I just realized that vim-noshadow-512.png is used to generate the document icons. I spent some time making a pixel-precise generic icon (using the large graphic on small versions gives a blurry result) but I have no idea how the current script works or how I can update it to ignore that file and just append the extension string at the bottom of the icon...

@kaishin
Copy link
Author

kaishin commented May 30, 2014

I uploaded a no-shadow version.

@ghost
Copy link

ghost commented Jun 4, 2014

May consider doing a "flat" style icon, since OSX yosemite has a metro-like flat icon style etc.

@kaishin
Copy link
Author

kaishin commented Jun 4, 2014

@prophittcorey The effect can be toned down, but Yosemite icons are not totally flat. See Mail.app and Messages.app, among others.

@kaishin
Copy link
Author

kaishin commented Jul 3, 2014

@b4winckler Any chance of getting some feedback on this?

@james2doyle
Copy link

I am using this for my MacVim already. If no one here wants it, you should check out the VimR project. He might be interested in a new icon since there is no default one.

@amw
Copy link

amw commented Jul 31, 2014

I really love this icon by Drew Yeaton. That's what I've set my MacVim to use.

https://dribbble.com/shots/337065-MacVim-Icon-Updated?list=users&offset=9

@james2doyle
Copy link

That icon is being used by the VimR Project

@amw
Copy link

amw commented Jul 31, 2014

Not sure if that's a problem. Icon was not created for VimR project specifically and we would probably get Drew's permission to use it for MacVim as well. Would only confuse those who have both apps installed, which I assume is not that many people.

@james2doyle
Copy link

I know that the VimR guy is going to have that icon tweaked to look better for Yosemite, right now it is that exact one. There is small likelihood that they will clash or be the same. It was more of a heads up.

@lucascaton
Copy link

As OS X Yosemite is coming with a new "flat" design I believe we should follow the same pattern in the new icon ツ

@jasonlong
Copy link

Here's a Yosemite version I put together. Happy to polish it up if you guys want to use it.

screen shot 2014-08-20 at 8 41 06 am

@amw
Copy link

amw commented Aug 20, 2014

My vote is still with the icon by Drew Yeaton. I've been using it on my Yosemite install and it fits nicely too.

@kaishin
Copy link
Author

kaishin commented Aug 20, 2014

@jasonlong like the spirit of this, but I'm not sure about the circle though. The V doesn't fit in there (too much space to its right) and circle icons are not recommended for text editors.

@amw That doesn't scream Vim to me as the capital V does.

I'm not trying to defend my original icon—it clearly needs some tweaks for Yosemite—but if this is going anywhere, we need to make sure that we end up with something better than what we have now.

Also, no collaborator/owner have chimed in yet.

@amw
Copy link

amw commented Aug 20, 2014

@kaishin it does say "vi". "vi" screams Vim to me even more than just capital V ;-)

Take a look on my Yosemite app switcher.

vim-switcher

@jasonlong
Copy link

circle icons are not recommended for text editors.

According to whom?

Also, I've gotta say that I don't think an icon based on TextMate's 2004 icon is the way forward here.

@PixelJanitor
Copy link

Grabs Popcorn

@caiogondim
Copy link

@jasonlong Do you have a link to your icon? Would love to use in my current MacVim

@jasonlong
Copy link

@caiogondim I'd like to make some tweaks to this one first. I'll drop a link here when I do.

@jwmann
Copy link

jwmann commented Aug 21, 2014

I like the direction @jasonlong is heading with the icon. Seems to fit more with the Yosemite styling than the Vi TextMate style icon. Still, it could use a bit more tweaking as you mentioned yourself.

@jasonlong
Copy link

Here's another take using the classic logo and Yosemite styling. I rounded the corners of the V to soften it a bit.

screen shot 2014-08-22 at 11 32 00 am

@jwmann
Copy link

jwmann commented Aug 22, 2014

I definitely like the approach of this revised version. It seems more of an evolution of the previous logo in order to match the new aesthetic of Yosemite.
I would like to see a little bit more contrast in this area but that might be just because of the compression/size of the jpg playing with my eyes.

@jasonlong
Copy link

@jwmann Good call. This version improves that edge and shows the icon in the context of some other Yosemite icons.

screen shot 2014-08-22 at 2 50 54 pm

@jwmann
Copy link

jwmann commented Aug 22, 2014

Very nice! Great job @jasonlong 👍
Hopefully everyone likes it as well and a Project Collaborator merges in the new Icon :)

@geetarista
Copy link

👍

@caiogondim
Copy link

@jasonlong Loved that new iteration.

@DomT4
Copy link

DomT4 commented Aug 24, 2014

This looks great in the dock alongside other Yosemite icons. Big 👍 from me.

@jasonlong
Copy link

I've created a pull at #44 with this proposed icon. I'm not sure if/when this will get merged, but feel free to grab it over there if you'd like to use it now.

@kaishin
Copy link
Author

kaishin commented Aug 27, 2014

@jasonlong

According to whom?

To me. There are no rules set in stone (I used 'recommended'), but a closer examination of the default app icons in Yosemite (http://martiancraft.com/blog/2014/07/inspecting-yosemite-icons/#the-shape-hierarchy) as well as a look at all document-based OS X apps from the last decade points to that.

In any case, I'm closing this due to irrelevance. There's been no input from the owners and I no longer use MacVim in favor of Terminal/tmux.

@kaishin kaishin closed this Aug 27, 2014
@jdsimcoe
Copy link

jdsimcoe commented Oct 6, 2014

@jasonlong Do you have a link to the ICNS and source files for this icon you created?

screenshot

@jwmann
Copy link

jwmann commented Oct 6, 2014

@jdsimcoe I think what you're looking for is referenced here - #44

EDIT:
Whoops, I see now that you meant the older version of the icon. Nothing to see here haha

@jdsimcoe
Copy link

jdsimcoe commented Oct 6, 2014

@jwmann yeah thanks I have those too, I like this specific one for personal use.

@jasonlong
Copy link

@jdsimcoe I can't seem to find that file on my computer. I can probably recreate it pretty easily though if you like.

@jdsimcoe
Copy link

jdsimcoe commented Oct 6, 2014

If it isn’t a big deal, otherwise it’s ok.

On Oct 6, 2014, at 10:44 AM, Jason Long [email protected] wrote:

@jdsimcoe https://github.com/jdsimcoe I can't seem to find that file on my computer. I can probably recreate it pretty easily though if you like.


Reply to this email directly or view it on GitHub #41 (comment).

splhack pushed a commit to splhack/macvim that referenced this pull request Jul 7, 2015
Fix crash when rendering invalid Unicode characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.