Pull request overview

This PR makes two changes to the CI workflow to improve bpf-linker installation: it enables static LLVM linking for macOS compatibility where dynamic libLLVM is unavailable, and corrects the Linux target triple to use musl instead of gnu, aligning with the already-configured musl toolchains.

Key Changes:

• Enable llvm-link-static feature for bpf-linker to support static LLVM linking on macOS
• Correct Linux target triple from gnu to musl to match installed toolchain targets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

💡 Codex Review

Here are some automated review suggestions for this pull request.

@tamird reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vadorovsky)

.github/workflows/ci.yml line 30 at r2 (raw file):

      - uses: dtolnay/rust-toolchain@stable

      - id: nightly-prefix

I think you don't need this as it is the default behavior

But it would be good to do it where we still have both toolchains to combine both versions

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @tamird)

.github/workflows/ci.yml line 30 at r2 (raw file):

Alright, I added it to the CI jobs that mix toolchains.

Approving to let you get on with your life but left some questions I'd like addressed

@tamird reviewed 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @vadorovsky)

.github/workflows/ci.yml line 158 at r6 (raw file):

        run: |
          set -euo pipefail
          prefix="$(rustc +nightly --version --verbose | awk '/commit-date/ {print "nightly-" $2}')"

should be commit-hash?

consider using the same logic as swatinem/rust-cache:

https://github.com/Swatinem/rust-cache/blob/42c55942cfd355e94e6864616f4dbb3392bd2789/src/config.ts#L383-L391

and

https://github.com/Swatinem/rust-cache/blob/42c55942cfd355e94e6864616f4dbb3392bd2789/src/config.ts#L105-L113

with a citation

.github/workflows/ci.yml line 163 at r6 (raw file):

      - uses: Swatinem/rust-cache@v2
        with:
          prefix-key: ${{ steps.nightly-prefix.outputs.value }}

why prefix-key rather than shared-key or just key?

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @tamird)

.github/workflows/ci.yml line 158 at r6 (raw file):

Just got an idea - instead of rewriting the logic on our own and crafting the cache key ourselves, we can just set

env:
  RUSTUP_TOOLCHAIN: nightly

just for this step, so then the action parses nightly's version.

@tamird reviewed 1 of 1 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @vadorovsky)

.github/workflows/ci.yml line 158 at r6 (raw file):

Yep this works -- it's a little fragile because the nightly isn't guaranteed to change when stable does, but almost certainly good though. Might be worth a mention in the comments.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @vadorovsky)

-- commits line 27 at r8:
Consider revising

Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @tamird)

.github/workflows/ci.yml line 158 at r6 (raw file):

it's a little fragile because the nightly isn't guaranteed to change when stable does

Good point.

Given that this part is not really essential to unblocking CI (at least for now), I just removed the last commit. so we can merge the uncontroversial part. We can figure out the correct keying based on stable+nightly separately. I'm wondering if we should raise the issue upstream and propose a solution (e.g. constructing a key based on all Rust toolchains installed).

Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @tamird)

-- commits line 27 at r8:

Removed the commit all together.

@tamird reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vadorovsky)

.github/workflows/ci.yml line 158 at r6 (raw file):

SG

Reviewable status: complete! all files reviewed, all discussions resolved

.github/workflows/ci.yml line 158 at r6 (raw file):

Swatinem/rust-cache#293