refactor: Proof.block_hash serde rename as proposal_hash#1618
Merged
Conversation
KaoImin
requested review from
Flouse,
ashuralyk and
chaoticlonghair
and removed request for
sunchengzhu
blckngm
reviewed
Dec 4, 2023
blckngm
reviewed
Dec 4, 2023
fix unit test
KaoImin
force-pushed
the
rename-block-hash
branch
from
682a409 to
295c6f8
Compare
blckngm
approved these changes
Dec 4, 2023
Contributor
|
/run-ci |
CI tests run on commit:
CI test list:
Please check ci test results later. |
chaoticlonghair
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To avoid ambiguity,
Proof.block_hashrename asproposal_hashwhenserde::serialize. It should fill the proposal hash.What is the impact of this PR?
No Breaking Change
PR relation:
block_hashfor a same height. #1506CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description