Skip to content

fix: duplicated calculation in eth_estimateGas#1599

Merged
KaoImin merged 1 commit intomainfrom
yangby/bugfix/duplicated-gas-estimation
Nov 30, 2023
Merged

fix: duplicated calculation in eth_estimateGas#1599
KaoImin merged 1 commit intomainfrom
yangby/bugfix/duplicated-gas-estimation

Conversation

@chaoticlonghair
Copy link
Copy Markdown
Contributor

@chaoticlonghair chaoticlonghair commented Nov 27, 2023 •
edited
Loading

What this PR does / why we need it?

This PR resolves #1584, but it's blocked by #1603.

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

p.s. This PR is created via GitHub CLI.

@chaoticlonghair
Copy link
Copy Markdown
Contributor Author

chaoticlonghair commented Nov 27, 2023

/run-ci

p.s. This comment is created via GitHub CLI.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 27, 2023

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@chaoticlonghair chaoticlonghair force-pushed the yangby/bugfix/duplicated-gas-estimation branch from a004ced to 44dc8db Compare November 29, 2023 09:03
@chaoticlonghair
Copy link
Copy Markdown
Contributor Author

chaoticlonghair commented Nov 29, 2023

/run-ci

p.s. This comment is created via GitHub CLI.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 29, 2023

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@chaoticlonghair chaoticlonghair marked this pull request as ready for review November 29, 2023 09:37
@chaoticlonghair chaoticlonghair requested a review from a team as a code owner November 29, 2023 09:37
@chaoticlonghair chaoticlonghair requested review from Flouse, KaoImin, ashuralyk and blckngm and removed request for ashuralyk and blckngm November 29, 2023 09:37
@Flouse Flouse requested a review from driftluo November 29, 2023 15:31
@KaoImin KaoImin added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 1092ca0 Nov 30, 2023
@chaoticlonghair chaoticlonghair deleted the yangby/bugfix/duplicated-gas-estimation branch December 7, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flouse Flouse Flouse approved these changes

@driftluo driftluo Awaiting requested review from driftluo

+1 more reviewer

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated calculation in eth_estimateGas.

3 participants

@chaoticlonghair @Flouse @KaoImin