Skip to content

fix: get genesis block proposal may panic#1554

Merged
KaoImin merged 1 commit intomainfrom
fix-get-proposal
Nov 15, 2023
Merged

fix: get genesis block proposal may panic#1554
KaoImin merged 1 commit intomainfrom
fix-get-proposal

Conversation

@KaoImin
Copy link
Copy Markdown
Contributor

@KaoImin KaoImin commented Nov 14, 2023

What this PR does / why we need it?

This PR fix the axon_getProposalByNumber with block number 0 may cause panic.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@KaoImin KaoImin requested a review from a team as a code owner November 14, 2023 03:11
@KaoImin KaoImin requested review from ashuralyk and jjyr November 14, 2023 03:11
@KaoImin KaoImin requested review from Flouse, chaoticlonghair and driftluo and removed request for ashuralyk and jjyr November 14, 2023 03:11
Comment thread core/api/src/jsonrpc/impl/axon.rs
@KaoImin KaoImin added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 9eb05dc Nov 15, 2023
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
@KaoImin KaoImin deleted the fix-get-proposal branch November 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants