fix: use a same default value for max_payload_size#1548
Merged
Conversation
chaoticlonghair
requested review from
Flouse and
Simon-Tl
and removed request for
ashuralyk and
blckngm
Contributor
|
It seems that the |
Flouse
previously approved these changes
Nov 13, 2023
Contributor
Yes, let's remove this useless config. |
Flouse
approved these changes
Nov 13, 2023
Simon-Tl
approved these changes
Nov 13, 2023
KaoImin
pushed a commit
that referenced
this pull request
Nov 17, 2023
* chore: use a same default value for `max_payload_size` * chore: remove the useless configuration field `client_version`
Flouse
changed the title
max_payload_sizemax_payload_size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR unifies the default value for
max_payload_size.axon/devtools/chain/k8s/node_1.toml
Line 12 in 9ad502d
axon/devtools/chain/nodes/node_1.toml
Line 12 in 9ad502d
Questions
Could I remove the
client_versionfield? Some configuration files have this field but some don't have.axon/devtools/chain/k8s/node_1.toml
Line 13 in 9ad502d
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description