Skip to content

style(axon-tools): rename some structs and change code style#1545

Merged
KaoImin merged 3 commits intoaxonweb3:mainfrom
wenyuanhust:main
Nov 17, 2023
Merged

style(axon-tools): rename some structs and change code style#1545
KaoImin merged 3 commits intoaxonweb3:mainfrom
wenyuanhust:main

Conversation

@wenyuanhust
Copy link
Copy Markdown
Contributor

@wenyuanhust wenyuanhust commented Nov 12, 2023 •
edited
Loading

What this PR does / why we need it?

This PR

  • delete duplicate test cases, it is the same as test_receipt in core/executor/src/lib.rs. There is no need to verify receipt based on axon and eth_light_client_in_ckb.
  • sync receipt calculation in test code test_exec.
  • keep the name of structs in axon-tools the same with axon-protocol, this will mitigate possible misunderstanding and benefit future updates

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@wenyuanhust wenyuanhust requested a review from a team as a code owner November 12, 2023 11:46
@KaoImin KaoImin changed the title refactor: axon-tools style(axon-tools): rename some strcuts and change code style Nov 16, 2023
@Flouse Flouse requested review from blckngm and removed request for jjyr November 16, 2023 06:34
@wenyuanhust wenyuanhust changed the title style(axon-tools): rename some strcuts and change code style style(axon-tools): rename some structs and change code style Nov 16, 2023
@KaoImin KaoImin added this pull request to the merge queue Nov 17, 2023
Merged via the queue into axonweb3:main with commit 06340ba Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashuralyk ashuralyk Awaiting requested review from ashuralyk ashuralyk is a code owner automatically assigned from axonweb3/axon-dev

2 more reviewers

@blckngm blckngm blckngm approved these changes

@KaoImin KaoImin KaoImin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenyuanhust @blckngm @KaoImin